Re: [PATCH] Revsion 2 of the security processor kernel driver;

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

On Thu, 23 Jul 2009 17:24:39 -0700
Greg KH <greg@kroah.com> wrote:

> On Thu, Jul 23, 2009 at 03:30:11PM -0700, Mark Allyn wrote:
> >  For the upstream community, this is revision 2. Changes are the
> >  relocation of this driver to the staging area.
> > 
> >  This is the Linux kernel driver for the Security Processor, which is
> >  a hardware device the provides cryptographic, secure storage, and
> >  key management services. 
> > 
> >  Please be aware that this patch does not contain any encryption
> >  algorithm. It only transports data to and from user space 
> >  applications to the security processor.
> > 
> >  Signed-off-by: Mark Allyn <mark.a.allyn@intel.com>
> 
> Can you provide me a TODO file that lists what is remaining to be done
> to this driver in order to get it accepted into the main portion of the
> kernel tree?

My guesses would be something like

- Fix firmware loading
- Get firmware into firmware git tree
- Review and tidy each algorithm function
- Check whether it can be plugged into any of the kernel crypto API
  interfaces
- Do something about the magic shared memory interface and replace it
  with something saner (in Linux terms)

The last one is non-trivial. The other security processors we have
support for also have fairly disgusting interfaces as do most of the user
space crypto library plugins. It doesn't seem to be something that
structures nicely (eg see the zSystem crypto driver we have now).

We may thus have to simply accept "Less ugly" unless anyone can point me
at a clean, well designed crypto processor API we could use.

Alan