mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@skynet.be>
To: Julia Lawall <julia@diku.dk>
Cc: linux-media@vger.kernel.org, linux-uvc-devel@lists.berlios.de,
	linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 2/5] drivers/media/video/uvc: Use DIV_ROUND_CLOSEST
Date: Sat, 1 Aug 2009 22:23:51 +0200	[thread overview]
Message-ID: <200908012223.52022.laurent.pinchart@skynet.be> (raw)
In-Reply-To: <Pine.LNX.4.64.0908012148420.25693@ask.diku.dk>

On Saturday 01 August 2009 21:49:04 Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @haskernel@
> @@
>
> #include <linux/kernel.h>
>
> @depends on haskernel@
> expression x,__divisor;
> @@
>
> - (((x) + ((__divisor) / 2)) / (__divisor))
> + DIV_ROUND_CLOSEST(x,__divisor)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
>
> ---
>  drivers/media/video/uvc/uvc_v4l2.c  |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/media/video/uvc/uvc_v4l2.c
> b/drivers/media/video/uvc/uvc_v4l2.c index 87cb9cc..6edaaf6 100644
> --- a/drivers/media/video/uvc/uvc_v4l2.c
> +++ b/drivers/media/video/uvc/uvc_v4l2.c
> @@ -95,7 +95,7 @@ static __u32 uvc_try_frame_interval(struct uvc_frame
> *frame, __u32 interval) const __u32 max = frame->dwFrameInterval[1];
>  		const __u32 step = frame->dwFrameInterval[2];
>
> -		interval = min + (interval - min + step/2) / step * step;
> +		interval = min + DIV_ROUND_CLOSEST(interval-min, step) * step;
>  		if (interval > max)
>  			interval = max;
>  	}

The purpose of the above code is to clamp the interval value to the [min, max] 
range at round it to the closest multiple of step. Other drivers might need 
similar code. Do you think it might be useful to introduce a clamp_step macro 
for this ?

If not,

Acked-by: Laurent Pinchart <laurent.pinchart@skynet.be>

Regards,

Laurent Pinchart


  reply	other threads:[~2009-08-01 20:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-01 19:49 Julia Lawall
2009-08-01 20:23 ` Laurent Pinchart [this message]
2009-08-02  6:20   ` Julia Lawall

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908012223.52022.laurent.pinchart@skynet.be \
    --to=laurent.pinchart@skynet.be \
    --cc=julia@diku.dk \
    --cc=kernel-janitors@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-uvc-devel@lists.berlios.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®