From: Borislav Petkov <petkovbb@googlemail.com>
To: Julia Lawall <julia@diku.dk>
Cc: linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 15/15] drivers/ide/ide-cd.c: Use DIV_ROUND_CLOSEST
Date: Sun, 2 Aug 2009 15:51:22 +0200 [thread overview]
Message-ID: <20090802135122.GA15279@liondog.tnic> (raw)
In-Reply-To: <Pine.LNX.4.64.0908021049350.15557@ask.diku.dk>
On Sun, Aug 02, 2009 at 10:49:54AM +0200, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
> but is perhaps more readable.
>
> The semantic patch that makes this change is as follows:
> (http://www.emn.fr/x-info/coccinelle/)
>
> // <smpl>
> @haskernel@
> @@
>
> #include <linux/kernel.h>
>
> @depends on haskernel@
> expression x,__divisor;
> @@
>
> - (((x) + ((__divisor) / 2)) / (__divisor))
> + DIV_ROUND_CLOSEST(x,__divisor)
> // </smpl>
>
> Signed-off-by: Julia Lawall <julia@diku.dk>
Acked-by: Borislav Petkov <petkovbb@gmail.com>
--
Regards/Gruss,
Boris.
next prev parent reply other threads:[~2009-08-02 13:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-02 8:49 Julia Lawall
2009-08-02 13:51 ` Borislav Petkov [this message]
2009-08-02 20:19 ` David Miller
[not found] ` <1249229645.22466.153.camel@Joe-Laptop.home>
[not found] ` <Pine.LNX.4.64.0908021822350.18361@ask.diku.dk>
[not found] ` <1249232640.22466.184.camel@Joe-Laptop.home>
[not found] ` <Pine.LNX.4.64.0908021908441.18361@ask.diku.dk>
2009-08-03 4:13 ` [RFC PATCH] scripts/get_maintainer.pl: Add optional "git blame" checking Joe Perches
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090802135122.GA15279@liondog.tnic \
--to=petkovbb@googlemail.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®