From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754264AbZHCI4l (ORCPT ); Mon, 3 Aug 2009 04:56:41 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751290AbZHCI4k (ORCPT ); Mon, 3 Aug 2009 04:56:40 -0400 Received: from mail-px0-f201.google.com ([209.85.216.201]:44557 "EHLO mail-px0-f201.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751026AbZHCI4j (ORCPT ); Mon, 3 Aug 2009 04:56:39 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-disposition:in-reply-to:user-agent; b=LWcsEeiUoq/vDEK85uv3PSm/aW9qsNW0OIzu5N1nMVzfJXkWJcRgVmVHbNl6e3jfcP n/CkfOFR5vkDaMhyvfIL0+JhC1765NqVjF7oG1aEHKGCSt/eLnlmHo+PZeyNm++S9svj x79fwNqf9alpllxuUOVAa5LjlY9xJ9bZOZlUQ= Date: Mon, 3 Aug 2009 16:58:53 +0800 From: Amerigo Wang To: Stefani Seibold Cc: linux-kernel@vger.kernel.org, Andrew Morton , sam@ravnborg.org Subject: Re: [PATCH] ctags usability fix Message-ID: <20090803085853.GB6016@cr0.nay.redhat.com> References: <1249114393.19594.16.camel@wall-e> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1249114393.19594.16.camel@wall-e> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 01, 2009 at 10:13:13AM +0200, Stefani Seibold wrote: >Hi, > >the tag file generated by the tags.sh script has some issue. > >First: > The identifier-list miss the > DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL > special handling, which can result in a wrong tag, not to jump to the > right variable definition or function implementation. > >Second: > It makes no real sense to include function prototypes and external and > forward variable declarations, because jumping to a tag will sometimes > go to this and not to the real definition and implementation. The information > about the declaration is still there at the definition and implementation > place. > >So this patch make it lot easier to navigate through the kernel source >tree using vi. Looks reasonable. Thanks. Acked-by: WANG Cong Sam? > >Greetings, >Stefani > > tags.sh | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >Signed-off-by: Stefani Seibold > >--- linux-2.6.30.orig/scripts/tags.sh 2009-06-10 05:05:27.000000000 +0200 >+++ linux-2.6.30/scripts/tags.sh 2009-08-01 09:46:56.000000000 +0200 >@@ -101,7 +101,8 @@ > -I ____cacheline_aligned_in_smp \ > -I ____cacheline_internodealigned_in_smp \ > -I EXPORT_SYMBOL,EXPORT_SYMBOL_GPL \ >- --extra=+f --c-kinds=+px \ >+ -I DEFINE_TRACE,EXPORT_TRACEPOINT_SYMBOL,EXPORT_TRACEPOINT_SYMBOL_GPL \ >+ --extra=+f --c-kinds=-px \ > --regex-asm='/^ENTRY\(([^)]*)\).*/\1/' \ > --regex-c='/^SYSCALL_DEFINE[[:digit:]]?\(([^,)]*).*/sys_\1/' > > >-- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/