From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754645AbZHCJUR (ORCPT ); Mon, 3 Aug 2009 05:20:17 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753706AbZHCJUO (ORCPT ); Mon, 3 Aug 2009 05:20:14 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:37204 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754410AbZHCJUL (ORCPT ); Mon, 3 Aug 2009 05:20:11 -0400 Date: Mon, 3 Aug 2009 11:19:54 +0200 From: Ingo Molnar To: Thomas Hellstrom Cc: Dave Airlie , Arjan van de Ven , "suresh.b.siddha@intel.com" , "hpa@zytor.com" , "linux-kernel@vger.kernel.org" , "venkatesh.pallipadi@intel.com" , "tglx@linutronix.de" , "dri-devel@lists.sourceforge.net" Subject: Re: [PATCH] x86: Fix CPA memtype reserving in the set_pages_array cases Message-ID: <20090803091954.GB9074@elte.hu> References: <1249284345-7654-1-git-send-email-thellstrom@vmware.com> <20090803081110.GB32258@elte.hu> <4A76A24F.1030505@vmware.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A76A24F.1030505@vmware.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Thomas Hellstrom wrote: > Dave Airlie wrote: >>> hm, i'm missing a description about how this bug was triggered. How >>> did you end up getting highmem pages to a cpa call? >>> >> >> GEM and TTM both allocate page arrays and just pass them to cpa, >> we don't know what type of pages the allocator gives us back and we >> really shouldn't have to, so having cpa ignore highmem pages is >> certainly the right option. >> >> GEM just uses shmem code to alloc the pages and TTM has its own allocator. >> >> > Yes, Dave is right. > > Although I'm not 100% sure the TTM code I was using that triggered this > has made it into 2.6.31. > Old AGP uses (GFP_KERNEL | GFP_DMA32 | __GFP_ZERO), which (correct me if > I'm wrong) never hands back highmem pages. This means that Intel's GEM > is the only likely user for 2.6.31. (please dont top-post) I'm not sure you folks noticed this bit of my mail: >>> ok, that's a bug introduced in .29 but which was latent until now: >>> drivers/char/agp/generic.c now uses it plus (indirectly) a number of >>> AGP drivers, since: >>> >>> commit 07613ba2f464f59949266f4337b75b91eb610795 >>> Author: Dave Airlie >>> Date: Fri Jun 12 14:11:41 2009 +1000 >>> >>> agp: switch AGP to use page array instead of unsigned long array >>> >>> I dont see how it can end up with highmem pages though. All the >>> graphics apperture allocations happen to lowmem AFAICS. Did GEM add >>> the possibility for user pages (highmem amongst them) ending up in >>> that pool? Which code does that? Ingo