From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933550AbZHECrC (ORCPT ); Tue, 4 Aug 2009 22:47:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S933389AbZHECrA (ORCPT ); Tue, 4 Aug 2009 22:47:00 -0400 Received: from mail-pz0-f196.google.com ([209.85.222.196]:40252 "EHLO mail-pz0-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933296AbZHECq7 (ORCPT ); Tue, 4 Aug 2009 22:46:59 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=date:from:to:cc:subject:message-id:in-reply-to:references:x-mailer :mime-version:content-type:content-transfer-encoding; b=BewfV7qE+K6K3QmbuZvjI7b/itP2UehP2/Y4kulILI2zAjIuT9afPO6BXlVfp2dmkV RjpkPTQXXeJjI9SQxq09rYwEb5gjK67JFvYojZaN9z7x3OJsqovLEJKlo2x8pElM2GWT 2Hd4a5kyNdmNTRwAUlBzvSpuSij7Y56twZiBY= Date: Wed, 5 Aug 2009 11:40:04 +0900 From: Minchan Kim To: KOSAKI Motohiro Cc: Minchan Kim , LKML , Paul Menage , David Rientjes , KAMEZAWA Hiroyuki , Rik van Riel , Andrew Morton , Linus Torvalds , Oleg Nesterov , linux-mm Subject: Re: [PATCH 1/4] oom: move oom_adj to signal_struct Message-Id: <20090805114004.459a7deb.minchan.kim@barrios-desktop> In-Reply-To: <20090805110107.5B97.A69D9226@jp.fujitsu.com> References: <20090804192514.6A40.A69D9226@jp.fujitsu.com> <20090805094534.35e64fbe.minchan.kim@barrios-desktop> <20090805110107.5B97.A69D9226@jp.fujitsu.com> X-Mailer: Sylpheed 2.6.0 (GTK+ 2.16.1; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 5 Aug 2009 11:29:34 +0900 (JST) KOSAKI Motohiro wrote: > Hi > > > Hi, Kosaki. > > > > I am so late to invole this thread. > > But let me have a question. > > > > What's advantage of placing oom_adj in singal rather than task ? > > I mean task->oom_adj and task->signal->oom_adj ? > > > > I am sorry if you already discussed it at last threads. > > Not sorry. that's very good question. > > I'm trying to explain the detailed intention of commit 2ff05b2b4eac > (move oom_adj to mm_struct). > > In 2.6.30, OOM logic callflow is here. > > __out_of_memory > select_bad_process for each task > badness calculate badness of one task > oom_kill_process search child > oom_kill_task kill target task and mm shared tasks with it > > example, process-A have two thread, thread-A and thread-B and it > have very fat memory. > And, each thread have following likes oom property. > > thread-A: oom_adj = OOM_DISABLE, oom_score = 0 > thread-B: oom_adj = 0, oom_score = very-high > > Then, select_bad_process() select thread-B, but oom_kill_task refuse > kill the task because thread-A have OOM_DISABLE. > __out_of_memory() call select_bad_process() again. but select_bad_process() > select the same task. It mean kernel fall in the livelock. > > The fact is, select_bad_process() must select killable task. otherwise > OOM logic go into livelock. > > Is this enough explanation? thanks. > Thanks for good explanation. :) It resulted from patch of David which moved task_struct->oom_ajd to mm_struct. I understood it. It meant oom_adj was not per-process. AFAIU, you want to make oom_adj per-process, again. And you selected the place with task->singal as per-process. What I have a question is that why do you select task_struct->signal rather than task_struct like old? What's benefit of using task_struct->signal ? -- Kind regards, Minchan Kim