From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner+w=401wt.eu-S964847AbZHERR2@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S964847AbZHERR2 (ORCPT <rfc822;w@1wt.eu>);
	Wed, 5 Aug 2009 13:17:28 -0400
Received: (majordomo@vger.kernel.org) by vger.kernel.org id S964838AbZHERR2
	(ORCPT <rfc822;linux-kernel-outgoing>);
	Wed, 5 Aug 2009 13:17:28 -0400
Received: from kroah.org ([198.145.64.141]:52384 "EHLO coco.kroah.org"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1755742AbZHERR0 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 5 Aug 2009 13:17:26 -0400
Date: Wed, 5 Aug 2009 10:15:47 -0700
From: Greg KH <greg@kroah.com>
To: Tejun Heo <tj@kernel.org>
Cc: Al Viro <viro@ftp.linux.org.uk>, Takashi Iwai <tiwai@suse.de>,
       Linux Kernel <linux-kernel@vger.kernel.org>, cguthrie@mandriva.org
Subject: Re: [PATCH 1/2] chrdev: implement __[un]register_chrdev()
Message-ID: <20090805171547.GB10443@kroah.com>
References: <4A79283E.7030202@kernel.org>
 <20090805161643.GA28436@kroah.com>
 <4A79B3A6.7090109@kernel.org>
 <20090805164919.GA27457@kroah.com>
 <4A79BB04.8000408@kernel.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <4A79BB04.8000408@kernel.org>
User-Agent: Mutt/1.5.20 (2009-06-14)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Thu, Aug 06, 2009 at 02:01:56AM +0900, Tejun Heo wrote:
> Greg KH wrote:
> > On Thu, Aug 06, 2009 at 01:30:30AM +0900, Tejun Heo wrote:
> >> Greg KH wrote:
> >>> On Wed, Aug 05, 2009 at 03:35:42PM +0900, Tejun Heo wrote:
> >>>> [un]register_chrdev() assume minor range 0-255.  This patch adds __
> >>>> prefixed versions which take @minorbase and @count explicitly.
> >>> What's the difference between this and the existing
> >>> register_chrdev_region() function?  Why doesn't that work for you?
> >>>
> >>> What am I missing here?
> >> The function names in char_dev.c are quite confusing.
> > 
> > That's an understatement :)
> 
> Yeah, it sure is.  It should have used a different verb at the very
> least.
> 
> >> register_chrdev_region() only registers chrdev region.
> >> register_chrdev() registers chrdev region and creates a cdev for the
> >> region.  :-)
> > 
> > Yes, but you can use register_chrdev_region() and then call cdev_alloc()
> > for the specific cdevs you need, right?  It's not the prettiest, but it
> > should work.
> 
> Yeap, I can.  That's basically what register_chrdev() is.  If it had a
> better name, adding a new variant would have been much nicer.  Having
> the helper makes sense tho.  Names too confusing?

Yes the names are confusing, the whole api needs a rework to make it
easier to understand :(

thanks,

greg k-h