From: Ingo Molnar <mingo@elte.hu>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Arnaldo Carvalho de Melo <acme@redhat.com>,
Mike Galbraith <efault@gmx.de>,
Steven Rostedt <rostedt@goodmis.org>,
Paul Mackerras <paulus@samba.org>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Gabriel Munteanu <eduard.munteanu@linux360.ro>,
Li Zefan <lizf@cn.fujitsu.com>,
Lai Jiangshan <laijs@cn.fujitsu.com>
Subject: Re: [PATCH] perfcounters: Support for ftrace event records sampling
Date: Fri, 7 Aug 2009 12:58:35 +0200 [thread overview]
Message-ID: <20090807105835.GB24916@elte.hu> (raw)
In-Reply-To: <1249641477.32113.664.camel@twins>
* Peter Zijlstra <a.p.zijlstra@chello.nl> wrote:
> On Fri, 2009-08-07 at 01:25 +0200, Frederic Weisbecker wrote:
> > This patch brings the kernel side support for ftrace event record
> > sampling.
> >
> > A new counter attribute is added: PERF_SAMPLE_TP_RECORD which requests
> > ftrace events record sampling.
> >
>
> > + PERF_SAMPLE_TP_RECORD = 1U << 10,
>
> I'd really want this thing called PERF_SAMPLE_RAW
yeah, i'd agree. I suggested to Frederic to use TP_RECORD but in
hindsight we are better off to handle PERF_SAMPLE_RAW as a 'non-ABI'
embelishment of samples, of not firmly defined content.
In the tracepoint case, that extra raw content is defined by:
/debug/tracing/events/*/format
and subject to changes.
Ingo
next prev parent reply other threads:[~2009-08-07 10:58 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-06 23:25 Frederic Weisbecker
2009-08-07 7:33 ` [tip:perfcounters/tracing] perf_counter: " tip-bot for Frederic Weisbecker
2009-08-07 10:11 ` Ingo Molnar
2009-08-07 20:22 ` Frederic Weisbecker
2009-08-07 10:37 ` [PATCH] perfcounters: " Peter Zijlstra
2009-08-07 10:58 ` Ingo Molnar [this message]
2009-08-07 20:09 ` Peter Zijlstra
2009-08-07 20:21 ` Frederic Weisbecker
2009-08-07 20:28 ` Peter Zijlstra
2009-08-07 20:36 ` Frederic Weisbecker
2009-08-07 20:26 ` Frederic Weisbecker
2009-08-07 15:54 ` Peter Zijlstra
2009-08-07 16:18 ` [tip:perfcounters/core] perfcounters: Support for ftrace event records sampling, fix modules tip-bot for Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807105835.GB24916@elte.hu \
--to=mingo@elte.hu \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@redhat.com \
--cc=eduard.munteanu@linux360.ro \
--cc=efault@gmx.de \
--cc=fweisbec@gmail.com \
--cc=laijs@cn.fujitsu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=paulus@samba.org \
--cc=penberg@cs.helsinki.fi \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®