From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932239AbZHGIwp (ORCPT ); Fri, 7 Aug 2009 04:52:45 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757179AbZHGIwo (ORCPT ); Fri, 7 Aug 2009 04:52:44 -0400 Received: from smtp.nokia.com ([192.100.122.230]:63241 "EHLO mgw-mx03.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757070AbZHGIwn convert rfc822-to-8bit (ORCPT ); Fri, 7 Aug 2009 04:52:43 -0400 From: Peter Ujfalusi To: ext Jarkko Nikula Subject: Re: [alsa-devel] [PATCH][2.6.31-rc5] ARM: OMAP: McBSP: Fix ASoC on OMAP1510 by fixing API of omap_mcbsp_start/stop Date: Fri, 7 Aug 2009 11:51:43 +0300 User-Agent: KMail/1.11.4 (Linux/2.6.30-gentoo-r4; KDE/4.2.4; i686; ; ) Cc: "alsa-devel@alsa-project.org" , "linux-kernel@vger.kernel.org" , Janusz Krzysztofik , Tony Lindgren , Mark Brown , "linux-omap@vger.kernel.org" References: <1249628387-7372-1-git-send-email-jhnikula@gmail.com> <200908071130.54337.peter.ujfalusi@nokia.com> <20090807114757.0067a707.jhnikula@gmail.com> In-Reply-To: <20090807114757.0067a707.jhnikula@gmail.com> MIME-Version: 1.0 Content-Type: Text/Plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Content-Disposition: inline Message-Id: <200908071151.44083.peter.ujfalusi@nokia.com> X-OriginalArrivalTime: 07 Aug 2009 08:51:50.0254 (UTC) FILETIME=[4DB318E0:01CA173C] X-Nokia-AV: Clean Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday 07 August 2009 11:47:57 ext Jarkko Nikula wrote: > On Fri, 7 Aug 2009 11:30:54 +0300 > > Peter Ujfalusi wrote: > > Looks nice, but I would have done it a bit differently... > > ... > > > > -void omap_mcbsp_start(unsigned int id); > > > -void omap_mcbsp_stop(unsigned int id); > > > +void omap_mcbsp_start(unsigned int id, int tx, int rx); > > > +void omap_mcbsp_stop(unsigned int id, int tx, int rx); > > > > void omap_mcbsp_start(unsigned int id, int dir); > > void omap_mcbsp_stop(unsigned int id, int dir); > > Valid point and cleans up a bit the ALSA SoC part of the patch. > However I didn't want to limit this generic arch/arm/plat-omap/mcbsp.c > into audio use case only. My change still allows to start transmitter > and receiver exactly at the same time. Might be worth if the > generic McBSP driver is used for something else than audio. Good point. -- Péter