mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre Habouzit <pierre.habouzit@intersec.com>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Pierre Habouzit <pierre.habouzit@intersec.com>,
	Ingo Molnar <mingo@elte.hu>, Paul Mackerras <paulus@samba.org>,
	linux-kernel@vger.kernel.org
Subject: Re: perf-record fix and UI improvement
Date: Fri, 7 Aug 2009 15:59:39 +0200	[thread overview]
Message-ID: <20090807135938.GB4844@laphroaig.corp> (raw)
In-Reply-To: <1249650066.32113.706.camel@twins>

On Fri, Aug 07, 2009 at 03:01:06PM +0200, Peter Zijlstra wrote:
> On Fri, 2009-08-07 at 14:15 +0200, Pierre Habouzit wrote:
> > I'm kind of new to the kernel world, so I hope I sent the patches to the
> > proper persons.
> 
> You did well for a first time ;-)

Well, sending patches is not really a first time, I kind of wrote most
of util/strbuf.[hc] and util/parse-options.[hc] ;)


> The things you can improve for next time are:
> 
>  - placing these nice descriptions you made above into the patches
> themselves, as esp the first patch has an empty changelog.

Right.

>  - get your email right :-)

*blush*

> Anyway, I think Ingo already fixed that up for you, so
> 
> Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>

Wonderful, thanks.

-- 
Intersec <http://www.intersec.com>
Pierre Habouzit <pierre.habouzit@intersec.com>
Tél : +33 (0)1 5570 3346
Mob : +33 (0)6 1636 8131
Fax : +33 (0)1 5570 3332
37 Rue Pierre Lhomme
92400 Courbevoie

  reply	other threads:[~2009-08-07 13:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07 12:15 Pierre Habouzit
2009-08-07 12:16 ` [PATCH 1/2] perf util: do_read should fail on EOF instead of busy-looping Pierre Habouzit
2009-08-07 12:16   ` [PATCH 2/2] perf-record: improve -A UI for empty or non-existent perf.data Pierre Habouzit
2009-08-07 15:10     ` [tip:perfcounters/urgent] perf record: Fix the " tip-bot for Pierre Habouzit
2009-08-07 15:09   ` [tip:perfcounters/urgent] perf util: Fix do_read() to fail on EOF instead of busy-looping tip-bot for Pierre Habouzit
2009-08-07 12:28 ` perf-record fix and UI improvement Pierre Habouzit
2009-08-07 13:01 ` Peter Zijlstra
2009-08-07 13:59   ` Pierre Habouzit [this message]
2009-08-07 15:09   ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090807135938.GB4844@laphroaig.corp \
    --to=pierre.habouzit@intersec.com \
    --cc=a.p.zijlstra@chello.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®