From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: lrg@slimlogic.co.uk, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/8] Regulator: Adding header file for TPS65023
Date: Fri, 7 Aug 2009 16:55:58 +0100 [thread overview]
Message-ID: <20090807155558.GJ639@sirena.org.uk> (raw)
In-Reply-To: <1249658736-10811-1-git-send-email-anuj.aggarwal@ti.com>
On Fri, Aug 07, 2009 at 08:55:36PM +0530, Anuj Aggarwal wrote:
This is OK but since you'll need to resubmit anyway it might be nice to
consider moving the register & bitfield definitions into the driver file
since they can't be used by any other code.
> +/* DCDC's */
Extra ' here :)
next prev parent reply other threads:[~2009-08-07 15:55 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 15:25 Anuj Aggarwal
2009-08-07 15:55 ` Mark Brown [this message]
2009-08-07 20:25 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807155558.GJ639@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anuj.aggarwal@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®