From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: lrg@slimlogic.co.uk, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/8] Regulator: Add TPS6507x regulator driver
Date: Fri, 7 Aug 2009 17:02:53 +0100 [thread overview]
Message-ID: <20090807160253.GK639@sirena.org.uk> (raw)
In-Reply-To: <1249658766-10859-1-git-send-email-anuj.aggarwal@ti.com>
On Fri, Aug 07, 2009 at 08:56:06PM +0530, Anuj Aggarwal wrote:
> Adding support for TI TPS6507x regulator driver
Exactly which chips does this driver support? Google tells me that at
least some of the parts in the TPS6507x range have functionality other
than regulator support on them like power path management and touch
which would mean that the drivers should be using the MFD framework to
hook in to the various subsystems unless the device presents as multiple
devices on the I2C bus.
Otherwise my comments here are essentially the same as for the previous
driver - it looks good but the same relatively minor issues apply.
next prev parent reply other threads:[~2009-08-07 16:02 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 15:26 Anuj Aggarwal
2009-08-07 16:02 ` Mark Brown [this message]
2009-08-07 20:27 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090807160253.GK639@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anuj.aggarwal@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®