mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: lrg@slimlogic.co.uk, linux-omap@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/8] Regulator: Adding TPS65023 and TPS6507x in Kconfig and Makefile
Date: Fri, 7 Aug 2009 17:07:29 +0100	[thread overview]
Message-ID: <20090807160728.GL639@sirena.org.uk> (raw)
In-Reply-To: <1249658960-11021-1-git-send-email-anuj.aggarwal@ti.com>

On Fri, Aug 07, 2009 at 08:59:20PM +0530, Anuj Aggarwal wrote:

> +config REGULATOR_TPS65023
> +	tristate "TI TPS65023 Power regulators"
> +	depends on OMAP3EVM_TPS65023
> +	help

...

> +config REGULATOR_TPS65073
> +	tristate "TI TPS65073 Power regulators"
> +	depends on OMAP3EVM_TPS65073

These dependencies on the OMAP3EVM seem very wrong - the only dependency
I'd expect would be on I2C (or a MFD core for the .

Also, the Kconfig stuff says TPS65073 but the driver said it supported
the entire TPS6507x line.  I'd expect these to be consistent with each
other.

      reply	other threads:[~2009-08-07 16:07 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-07 15:29 Anuj Aggarwal
2009-08-07 16:07 ` Mark Brown [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090807160728.GL639@sirena.org.uk \
    --to=broonie@opensource.wolfsonmicro.com \
    --cc=anuj.aggarwal@ti.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=lrg@slimlogic.co.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®