From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Anuj Aggarwal <anuj.aggarwal@ti.com>
Cc: lrg@slimlogic.co.uk, linux-omap@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 6/8] Regulator: Add board-omap35x-pmic.c to arch/arm/mach-omap2/
Date: Sat, 8 Aug 2009 08:41:36 +0100 [thread overview]
Message-ID: <20090808074135.GA4519@sirena.org.uk> (raw)
In-Reply-To: <1249658966-11062-1-git-send-email-anuj.aggarwal@ti.com>
On Fri, Aug 07, 2009 at 08:59:26PM +0530, Anuj Aggarwal wrote:
> Added arch/arm/mach-omap2/board-omap35x-pmic.c file which will
> have the board specific information for different regulators
> and will do the regulator initialization depending on the one
> which is available.
Should this have an "evm" or something in the filename, possibly? There
will be some boards that aren't so directly cloned from the reference
designs.
> +static inline int detect_pmic(void)
> +{
> +#if defined(CONFIG_TWL4030_CORE)
> + flag_pmic_twl4030 = 1;
> +#endif
This isn't actually detecting anything on the board, it's just flagging
the things that have drivers built in. Will everything continue to work
OK if support for more than one of the PMICs is built into the kernel or
will things break? If they'll break you might want to have something to
detect that and flag it up.
> +int oma35x_pmic_init(void)
> +{
Typo there.
next prev parent reply other threads:[~2009-08-08 7:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 15:29 Anuj Aggarwal
2009-08-08 7:41 ` Mark Brown [this message]
2009-08-10 7:32 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090808074135.GA4519@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=anuj.aggarwal@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=lrg@slimlogic.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®