From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751568AbZHHPC4 (ORCPT ); Sat, 8 Aug 2009 11:02:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751339AbZHHPC4 (ORCPT ); Sat, 8 Aug 2009 11:02:56 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:50734 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751292AbZHHPCz (ORCPT ); Sat, 8 Aug 2009 11:02:55 -0400 Date: Sat, 8 Aug 2009 17:02:42 +0200 From: Ingo Molnar To: Yinghai Lu Cc: Thomas Gleixner , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH] x86: reget cfg_new in case reuse/move irq_desc Message-ID: <20090808150242.GA28892@elte.hu> References: <4A785AB6.3020803@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A785AB6.3020803@kernel.org> User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.5 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Yinghai Lu wrote: > when irq_desc is moved, we need to make sure to use right cfg_new > > Signed-off-by: Yinghai Lu > > --- > arch/x86/kernel/apic/io_apic.c | 1 + > 1 file changed, 1 insertion(+) > > Index: linux-2.6/arch/x86/kernel/apic/io_apic.c > =================================================================== > --- linux-2.6.orig/arch/x86/kernel/apic/io_apic.c > +++ linux-2.6/arch/x86/kernel/apic/io_apic.c > @@ -3153,6 +3153,7 @@ unsigned int create_irq_nr(unsigned int > continue; > > desc_new = move_irq_desc(desc_new, node); > + cfg_new = desc_new->chip_data; > i suspect we need this for .31? Did you see any actual bug due to this? (if yes, how did it look like?) Ingo