From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698AbZHJIAx (ORCPT ); Mon, 10 Aug 2009 04:00:53 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752569AbZHJIAw (ORCPT ); Mon, 10 Aug 2009 04:00:52 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:46894 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751192AbZHJIAw (ORCPT ); Mon, 10 Aug 2009 04:00:52 -0400 Date: Mon, 10 Aug 2009 10:00:49 +0200 From: Wolfram Sang To: Marcin Slusarz Cc: LKML , Paul Mackerras , linuxppc-dev@ozlabs.org Subject: Re: [PATCH 03/14] powerpc: use printk_once Message-ID: <20090810080049.GA3132@pengutronix.de> References: <1249847649-11631-1-git-send-email-marcin.slusarz@gmail.com> <1249847649-11631-4-git-send-email-marcin.slusarz@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="vtzGhvizbBRQ85DL" Content-Disposition: inline In-Reply-To: <1249847649-11631-4-git-send-email-marcin.slusarz@gmail.com> User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:221:70ff:fe71:1890 X-SA-Exim-Mail-From: w.sang@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --vtzGhvizbBRQ85DL Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Sun, Aug 09, 2009 at 09:53:58PM +0200, Marcin Slusarz wrote: > Signed-off-by: Marcin Slusarz > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: linuxppc-dev@ozlabs.org > --- > arch/powerpc/kernel/iommu.c | 6 +----- > arch/powerpc/kernel/irq.c | 5 ++--- > arch/powerpc/sysdev/ppc4xx_pci.c | 9 ++------- > 3 files changed, 5 insertions(+), 15 deletions(-) >=20 > diff --git a/arch/powerpc/kernel/iommu.c b/arch/powerpc/kernel/iommu.c > index fd51578..c7fa258 100644 > --- a/arch/powerpc/kernel/iommu.c > +++ b/arch/powerpc/kernel/iommu.c > @@ -502,7 +502,6 @@ static void iommu_table_clear(struct iommu_table *tbl) > struct iommu_table *iommu_init_table(struct iommu_table *tbl, int nid) > { > unsigned long sz; > - static int welcomed =3D 0; > struct page *page; > =20 > /* Set aside 1/4 of the table for large allocations. */ > @@ -523,11 +522,8 @@ struct iommu_table *iommu_init_table(struct iommu_ta= ble *tbl, int nid) > =20 > iommu_table_clear(tbl); > =20 > - if (!welcomed) { > - printk(KERN_INFO "IOMMU table initialized, virtual merging %s\n", > + printk_once(KERN_INFO "IOMMU table initialized, virtual merging %s\n", > novmerge ? "disabled" : "enabled"); > - welcomed =3D 1; > - } > =20 > return tbl; > } > diff --git a/arch/powerpc/kernel/irq.c b/arch/powerpc/kernel/irq.c > index f7f376e..05ebd21 100644 > --- a/arch/powerpc/kernel/irq.c > +++ b/arch/powerpc/kernel/irq.c > @@ -231,7 +231,6 @@ skip: > void fixup_irqs(cpumask_t map) > { > unsigned int irq; > - static int warned; > =20 > for_each_irq(irq) { > cpumask_t mask; > @@ -246,8 +245,8 @@ void fixup_irqs(cpumask_t map) > } > if (irq_desc[irq].chip->set_affinity) > irq_desc[irq].chip->set_affinity(irq, &mask); > - else if (irq_desc[irq].action && !(warned++)) > - printk("Cannot set affinity for irq %i\n", irq); > + else if (irq_desc[irq].action) > + printk_once("Cannot set affinity for irq %i\n", irq); Maybe we should add a loglevel to this printk (and the other one in fix_irq= s) while we are here? Other than that: Acked-by: Wolfram Sang --=20 Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ | --vtzGhvizbBRQ85DL Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.9 (GNU/Linux) iEYEARECAAYFAkp/07EACgkQD27XaX1/VRv0WwCfUhSxu3pv3YoG2OWL5O4vahPc NksAoL0PRBVRNKHAvWqoYKMChO+5RSN6 =svFT -----END PGP SIGNATURE----- --vtzGhvizbBRQ85DL--