From: Jesse Barnes <jesse.barnes@intel.com>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
Ingo Molnar <mingo@elte.hu>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] pci: print out pref if mmio is prefetchable
Date: Mon, 10 Aug 2009 09:27:31 -0700 [thread overview]
Message-ID: <20090810092731.7a44c24e@jbarnes-g45> (raw)
In-Reply-To: <4A7C07AE.4040200@kernel.org>
On Fri, 07 Aug 2009 03:53:34 -0700
Yinghai Lu <yinghai@kernel.org> wrote:
>
> already print it out for pci bridge, also print it out for pci device
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> drivers/pci/probe.c | 9 +++++++--
> 1 file changed, 7 insertions(+), 2 deletions(-)
>
> Index: linux-2.6/drivers/pci/probe.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/probe.c
> +++ linux-2.6/drivers/pci/probe.c
> @@ -235,7 +235,10 @@ int __pci_read_base(struct pci_dev *dev,
> res->start = l64;
> res->end = l64 + sz64;
> dev_printk(KERN_DEBUG, &dev->dev,
> - "reg %x 64bit mmio: %pR\n", pos,
> res);
> + "reg %x %s: %pR\n", pos,
> + (res->flags & IORESOURCE_PREFETCH) ?
> + "64bit mmio pref" : "64bit
> mmio",
> + res);
> }
>
> res->flags |= IORESOURCE_MEM_64;
> @@ -249,7 +252,9 @@ int __pci_read_base(struct pci_dev *dev,
> res->end = l + sz;
>
> dev_printk(KERN_DEBUG, &dev->dev, "reg %x %s:
> %pR\n", pos,
> - (res->flags & IORESOURCE_IO) ? "io port" :
> "32bit mmio",
> + (res->flags & IORESOURCE_IO) ? "io port" :
> + ((res->flags & IORESOURCE_PREFETCH) ?
> + "32bit mmio pref" : "32bit mmio"),
> res);
> }
>
>
Applied to linux-next, thanks.
--
Jesse Barnes, Intel Open Source Technology Center
prev parent reply other threads:[~2009-08-10 16:27 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-07 10:53 Yinghai Lu
2009-08-10 16:27 ` Jesse Barnes [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090810092731.7a44c24e@jbarnes-g45 \
--to=jesse.barnes@intel.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®