From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755137AbZHJOJE (ORCPT ); Mon, 10 Aug 2009 10:09:04 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754985AbZHJOJD (ORCPT ); Mon, 10 Aug 2009 10:09:03 -0400 Received: from mx2.redhat.com ([66.187.237.31]:55742 "EHLO mx2.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754806AbZHJOJC (ORCPT ); Mon, 10 Aug 2009 10:09:02 -0400 Date: Mon, 10 Aug 2009 10:08:18 -0400 From: Jeff Layton To: Christoph Hellwig Cc: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, akpm@linux-foundation.org, hch@infradead.org, rlove@google.com, msb@google.com, viro@zeniv.linux.org.uk, hannes@cmpxchg.org Subject: Re: [PATCH 1/3] vfs: make get_sb_pseudo set s_maxbytes to value that can be cast to signed Message-ID: <20090810100818.3c17def9@tlielax.poochiereds.net> In-Reply-To: <20090810134950.GA16276@infradead.org> References: <1249906663-7572-1-git-send-email-jlayton@redhat.com> <1249906663-7572-2-git-send-email-jlayton@redhat.com> <20090810134950.GA16276@infradead.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 10 Aug 2009 09:49:50 -0400 Christoph Hellwig wrote: > On Mon, Aug 10, 2009 at 08:17:41AM -0400, Jeff Layton wrote: > > get_sb_pseudo sets s_maxbytes to ~0ULL which becomes negative when cast > > to a signed value. Fix it to use MAX_LFS_FILESIZE which casts properly > > to a positive signed value. > > > > Signed-off-by: Jeff Layton > > Reviewed-by: Johannes Weiner > > Acked-by: Steve French > > Looks good, and I think it would be very good to still gets this into > 2.6.31. > > Reviewed-by: Christoph Hellwig > Agreed. The other two should probably go in early 2.6.32 (assuming they're ok). -- Jeff Layton