From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754213AbZHJXHT (ORCPT ); Mon, 10 Aug 2009 19:07:19 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754071AbZHJXHS (ORCPT ); Mon, 10 Aug 2009 19:07:18 -0400 Received: from rcsinet12.oracle.com ([148.87.113.124]:64714 "EHLO rgminet12.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751797AbZHJXHQ (ORCPT ); Mon, 10 Aug 2009 19:07:16 -0400 Date: Mon, 10 Aug 2009 16:04:55 -0700 From: Randy Dunlap To: Stephen Rothwell , linux-media@vger.kernel.org, akpm Cc: linux-next@vger.kernel.org, LKML , Michael Krufky , Uri Shkolnik Subject: [PATCH -next] dvb: siano uses/depends on INPUT Message-Id: <20090810160455.4f93ad60.randy.dunlap@oracle.com> In-Reply-To: <20090810203508.f3258129.sfr@canb.auug.org.au> References: <20090810203508.f3258129.sfr@canb.auug.org.au> Organization: Oracle Linux Eng. X-Mailer: Sylpheed 2.7.0 (GTK+ 2.12.0; x86_64-unknown-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Source-IP: abhmt004.oracle.com [141.146.116.13] X-Auth-Type: Internal IP X-CT-RefId: str=0001.0A010209.4A80A7C9.00C5:SCFSTAT5015188,ss=1,fgs=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Randy Dunlap siano uses input_*() functions so it should depend on INPUT to prevent build errors: ERROR: "input_event" [drivers/media/dvb/siano/sms1xxx.ko] undefined! ERROR: "input_register_device" [drivers/media/dvb/siano/sms1xxx.ko] undefined! ERROR: "input_free_device" [drivers/media/dvb/siano/sms1xxx.ko] undefined! ERROR: "input_unregister_device" [drivers/media/dvb/siano/sms1xxx.ko] undefined! ERROR: "input_allocate_device" [drivers/media/dvb/siano/sms1xxx.ko] undefined! Signed-off-by: Randy Dunlap Cc: Michael Krufky Cc: Uri Shkolnik --- drivers/media/dvb/siano/Kconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-next-20090810.orig/drivers/media/dvb/siano/Kconfig +++ linux-next-20090810/drivers/media/dvb/siano/Kconfig @@ -4,7 +4,7 @@ config DVB_SIANO_SMS1XXX tristate "Siano SMS1XXX USB dongle support" - depends on DVB_CORE && USB + depends on DVB_CORE && USB && INPUT ---help--- Choose Y here if you have a USB dongle with a SMS1XXX chipset. --- ~Randy LPC 2009, Sept. 23-25, Portland, Oregon http://linuxplumbersconf.org/2009/