mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Blum <bblum@google.com>
To: linux-kernel@vger.kernel.org,
	containers@lists.linux-foundation.org, akpm@linux-foundation.org,
	serue@us.ibm.com, lizf@cn.fujitsu.com, menage@google.com,
	bblum@google.com
Subject: [PATCH v3 0/7] CGroups: cgroup memberlist enhancement+fix
Date: Mon, 10 Aug 2009 17:57:30 -0700	[thread overview]
Message-ID: <20090811004737.21950.29188.stgit@hastromil.mtv.corp.google.com> (raw)

(This patch series is a revision of http://lkml.org/lkml/2009/7/30/382 .)

The following series adds a "cgroup.procs" file to each cgroup that reports
unique tgids rather than pids, which can also be written to for moving all
threads in a threadgroup at once.

Patch #5 modifies the subsystem attach interface to be able to attach whole
threadgroups at a time, which could introduce potential problems if any
subsystem were to need the old cgroup of every thread being moved. The attach
interface would need to be revised if this becomes the case.

Patch #6 implements functionality for read/write locking all CLONE_THREAD
fork()ing within a threadgroup, by means of an rwsem that lives in the
sighand_struct, for per-threadgroup-ness and also for sharing a cacheline with
the sighand's atomic count. This scheme should introduce no extra overhead in
the fork path when there's no contention.

Patch #7 reveals potential for a race when forking before a subsystem's attach
function is called - one potential solution in case any subsystem has this
problem is to hang on to the group's fork mutex through the attach() calls,
though no subsystem yet demonstrates need for an extended critical section.

This patch series was written at the same time as Li Zefan's pid namespace
bugfix patch (from http://lkml.org/lkml/2009/7/1/559 ), and contains a similar
but finer-grained fix for the same bug. These patches can either be rewritten
to be applied on top of Li's patch, or be applied as they are with Li's patch
reversed.

---

Ben Blum (7):
      Makes procs file writable to move all threads by tgid at once
      Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup
      Lets ss->can_attach and ss->attach do whole threadgroups at a time
      Changes css_set freeing mechanism to be under RCU
      Quick vmalloc vs kmalloc fix to the case where array size is too large
      Ensures correct concurrent opening/reading of pidlists across pid namespaces
      Adds a read-only "procs" file similar to "tasks" that shows only unique tgids


 Documentation/cgroups/cgroups.txt |   25 +
 include/linux/cgroup.h            |   70 ++-
 include/linux/init_task.h         |    9 
 include/linux/sched.h             |   15 +
 kernel/cgroup.c                   |  881 +++++++++++++++++++++++++++++++------
 kernel/cgroup_freezer.c           |   15 +
 kernel/cpuset.c                   |   66 ++-
 kernel/fork.c                     |    9 
 kernel/ns_cgroup.c                |   16 +
 kernel/sched.c                    |   35 +
 mm/memcontrol.c                   |    3 
 security/device_cgroup.c          |    3 
 12 files changed, 954 insertions(+), 193 deletions(-)


             reply	other threads:[~2009-08-11  0:57 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-11  0:57 Ben Blum [this message]
2009-08-11  0:57 ` [PATCH 1/7] Adds a read-only "procs" file similar to "tasks" that shows only unique tgids Ben Blum
2009-08-11  0:57 ` [PATCH 2/7] Ensures correct concurrent opening/reading of pidlists across pid namespaces Ben Blum
2009-08-11  0:57 ` [PATCH 3/7] Quick vmalloc vs kmalloc fix to the case where array size is too large Ben Blum
2009-08-11  0:57 ` [PATCH 4/7] Changes css_set freeing mechanism to be under RCU Ben Blum
2009-08-11  0:57 ` [PATCH 5/7] Lets ss->can_attach and ss->attach do whole threadgroups at a time Ben Blum
2009-08-11  0:58 ` [PATCH 6/7] Adds functionality to read/write lock CLONE_THREAD fork()ing per-threadgroup Ben Blum
2009-08-11  0:58 ` [PATCH 7/7] Makes procs file writable to move all threads by tgid at once Ben Blum
2009-08-18 21:33 ` [PATCH v3 0/7] CGroups: cgroup memberlist enhancement+fix Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090811004737.21950.29188.stgit@hastromil.mtv.corp.google.com \
    --to=bblum@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=containers@lists.linux-foundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=menage@google.com \
    --cc=serue@us.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®