From: Ingo Molnar <mingo@elte.hu>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Jesse Barnes <jbarnes@virtuousgeek.org>,
mingo@redhat.com, hpa@zytor.com, suresh.b.siddha@intel.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>
Subject: Re: [PATCH] pci/intr_remapping: allocate irq_iommu on node -v2
Date: Tue, 11 Aug 2009 09:34:11 +0200 [thread overview]
Message-ID: <20090811073411.GB17476@elte.hu> (raw)
In-Reply-To: <4A80E2E2.5000208@kernel.org>
* Yinghai Lu <yinghai@kernel.org> wrote:
> static struct irq_2_iommu *irq_2_iommu_alloc(unsigned int irq)
> {
> - return irq_2_iommu_alloc_node(irq, cpu_to_node(boot_cpu_id));
> + int node;
> +
> +#ifdef CONFIG_SMP
> + node = irq_to_desc(irq)->node;
> +#else
> + node = cpu_to_node(boot_cpu_id);
> +#endif
> +
> + return irq_2_iommu_alloc_node(irq, node);
> }
To avoid the ifdef, shouldnt there be an new irq_node(irq) primitive
that maps to desc->node on SMP and does the right thing on UP?
Ingo
prev parent reply other threads:[~2009-08-11 13:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 16:04 [PATCH] pci/intr_remapping: allocate irq_iommu on node Yinghai Lu
2009-08-04 17:19 ` Suresh Siddha
2009-08-05 9:14 ` Yinghai Lu
2009-08-06 0:36 ` Suresh Siddha
2009-08-06 1:19 ` Yinghai Lu
2009-08-06 19:16 ` Suresh Siddha
2009-08-08 15:22 ` [tip:irq/core] pci/intr_remapping: Allocate " tip-bot for Yinghai Lu
2009-08-09 10:44 ` Ingo Molnar
2009-08-10 16:29 ` Jesse Barnes
2009-08-11 3:17 ` [PATCH] pci/intr_remapping: allocate irq_iommu on node -v2 Yinghai Lu
2009-08-11 7:34 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090811073411.GB17476@elte.hu \
--to=mingo@elte.hu \
--cc=hpa@zytor.com \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®