From: David Miller <davem@davemloft.net>
To: jpirko@redhat.com
Cc: akpm@linux-foundation.org, mingo@elte.hu, a.p.zijlstra@chello.nl,
torvalds@linux-foundation.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, eric.dumazet@gmail.com
Subject: Re: [PATCH] net: Fix spinlock use in alloc_netdev_mq()
Date: Wed, 12 Aug 2009 16:44:12 -0700 (PDT) [thread overview]
Message-ID: <20090812.164412.266822784.davem@davemloft.net> (raw)
In-Reply-To: <20090806083102.GA3737@psychotron.englab.brq.redhat.com>
From: Jiri Pirko <jpirko@redhat.com>
Date: Thu, 6 Aug 2009 10:31:02 +0200
> Hmm, I see your point here. Eric previously posted patch which moved spin lock
> init into alloc_netdev_mq(). But he was worried about having it here and
> netdev_set_addr_lockdep_class() in register_netdevice() (because before
> dev_unicast_init() dev->type is not set). So how about the following patch?
Well, because of those potential late dev->type settings we
can't do things this way. And I believe those in fact do happen.
So I'm tossing this patch, I wouldn't have applied it to net-2.6
anyways, as it's net-next-2.6 material :-)
next prev parent reply other threads:[~2009-08-12 23:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-04 19:57 [GIT]: Networking David Miller
2009-08-05 7:02 ` Ingo Molnar
2009-08-05 7:14 ` Ingo Molnar
2009-08-05 7:16 ` [PATCH] net: Fix spinlock use in alloc_netdev_mq() Ingo Molnar
2009-08-05 8:47 ` Jiri Pirko
2009-08-05 15:37 ` David Miller
2009-08-05 17:13 ` Andrew Morton
2009-08-06 8:31 ` Jiri Pirko
2009-08-12 23:44 ` David Miller [this message]
2009-08-05 7:19 ` [GIT]: Networking Eric Dumazet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812.164412.266822784.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=eric.dumazet@gmail.com \
--cc=jpirko@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=netdev@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome