From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752463AbZHLLjP (ORCPT ); Wed, 12 Aug 2009 07:39:15 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751731AbZHLLjP (ORCPT ); Wed, 12 Aug 2009 07:39:15 -0400 Received: from metis.ext.pengutronix.de ([92.198.50.35]:54485 "EHLO metis.ext.pengutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751627AbZHLLjO (ORCPT ); Wed, 12 Aug 2009 07:39:14 -0400 Date: Wed, 12 Aug 2009 13:39:13 +0200 From: Sascha Hauer To: Alessandro Zummo Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.arm.linux.org.uk, Paul Gortmaker , rtc-linux@googlegroups.com Subject: Re: [PATCH 4/5] [RTC] Add Freescale MC13783 RTC driver Message-ID: <20090812113913.GE17992@pengutronix.de> References: <1249981166-4210-1-git-send-email-s.hauer@pengutronix.de> <1249981166-4210-2-git-send-email-s.hauer@pengutronix.de> <1249981166-4210-3-git-send-email-s.hauer@pengutronix.de> <1249981166-4210-4-git-send-email-s.hauer@pengutronix.de> <20090812114134.421303c4@i1501.lan.towertech.it> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20090812114134.421303c4@i1501.lan.towertech.it> X-Sent-From: Pengutronix Entwicklungszentrum Nord - Hildesheim X-URL: http://www.pengutronix.de/ X-IRC: #ptxdist @freenode X-Accept-Language: de,en X-Accept-Content-Type: text/plain X-Impressum: Pengutronix - Linux Solutions for Science and Industry Handelsregister: Amtsgericht Hildesheim, HRA 2686 Peiner Strasse 6-8, 31137 Hildesheim, Germany Phone: +49-5121-206917-0 | Fax: +49-5121-206917-5555 Inhaber: Dipl.-Ing. Robert Schwebel X-Message-Flag: See Message Headers for Impressum X-Uptime: 13:37:09 up 6 days, 22:56, 27 users, load average: 0.06, 0.59, 0.94 User-Agent: Mutt/1.5.18 (2008-05-17) X-SA-Exim-Connect-IP: 2001:6f8:1178:2:215:17ff:fe12:23b0 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-kernel@vger.kernel.org Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Allessandro, I addressed your comments. Will be fixed next round. Thanks for reviewing, Sascha On Wed, Aug 12, 2009 at 11:41:34AM +0200, Alessandro Zummo wrote: > On Tue, 11 Aug 2009 10:59:25 +0200 > Sascha Hauer wrote: > > > This driver provides support for the RTC part integrated into > > the Freescale MC13783 PMIC. > > > > Signed-off-by: Sascha Hauer > > Cc: Paul Gortmaker > > Cc: Alessandro Zummo > > Cc: rtc-linux@googlegroups.com > > > thanks for your submission, comments below > > > --- > > drivers/rtc/Kconfig | 6 ++ > > drivers/rtc/Makefile | 1 + > > drivers/rtc/rtc-mc13783.c | 141 +++++++++++++++++++++++++++++++++++++++++++++ > > 3 files changed, 148 insertions(+), 0 deletions(-) > > create mode 100644 drivers/rtc/rtc-mc13783.c > > > > diff --git a/drivers/rtc/Kconfig b/drivers/rtc/Kconfig > > index 81adbdb..e4a242f 100644 > > --- a/drivers/rtc/Kconfig > > +++ b/drivers/rtc/Kconfig > > @@ -759,4 +759,10 @@ config RTC_DRV_PS3 > > This driver can also be built as a module. If so, the module > > will be called rtc-ps3. > > > > +config RTC_DRV_MC13783 > > + depends on MFD_MC13783 > > + tristate "Freescale MC13783 RTC" > > + help > > + This enables support for the Freescale MC13783 PMIC RTC > > + > > endif # RTC_CLASS > > diff --git a/drivers/rtc/Makefile b/drivers/rtc/Makefile > > index 3c0f2b2..00bf66d 100644 > > --- a/drivers/rtc/Makefile > > +++ b/drivers/rtc/Makefile > > @@ -78,3 +78,4 @@ obj-$(CONFIG_RTC_DRV_WM8350) += rtc-wm8350.o > > obj-$(CONFIG_RTC_DRV_X1205) += rtc-x1205.o > > obj-$(CONFIG_RTC_DRV_PCF50633) += rtc-pcf50633.o > > obj-$(CONFIG_RTC_DRV_PS3) += rtc-ps3.o > > +obj-$(CONFIG_RTC_DRV_MC13783) += rtc-mc13783.o > > keep in in alphabetic order. > > > diff --git a/drivers/rtc/rtc-mc13783.c b/drivers/rtc/rtc-mc13783.c > > new file mode 100644 > > index 0000000..d1f1192 > > --- /dev/null > > +++ b/drivers/rtc/rtc-mc13783.c > > @@ -0,0 +1,141 @@ > > +/* > > + * Real Time Clock driver for Freescale MC13783 PMIC > > + * > > + * (C) 2009 Sascha Hauer, Pengutronix > > + * > > + * This program is free software; you can redistribute it and/or modify > > + * it under the terms of the GNU General Public License as published by > > + * the Free Software Foundation; either version 2 of the License, or > > + * (at your option) any later version. > > + * > > + * This program is distributed in the hope that it will be useful, > > + * but WITHOUT ANY WARRANTY; without even the implied warranty of > > + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the > > + * GNU General Public License for more details. > > + * > > + * You should have received a copy of the GNU General Public License > > + * along with this program; if not, write to the Free Software > > + * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA. > > + */ > > + > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > +#include > > too many includes? > > > + > > +struct mc13783_rtc { > > + struct rtc_device *rtc; > > + struct mc13783 *mc13783; > > +}; > > + > > +static int mc13783_rtc_set_time(struct device *dev, struct rtc_time *tm) > > please implement set_mmss instad of set_time > > > + struct mc13783_rtc *priv = dev_get_drvdata(dev); > > + unsigned int seconds, days; > > + unsigned long s1970; > > + > > + rtc_tm_to_time(tm, &s1970); > > + > > + seconds = s1970 % 86400; > > + days = s1970 / 86400; > > + > > + mc13783_reg_write(priv->mc13783, MC13783_REG_RTC_TIME, seconds); > > + mc13783_reg_write(priv->mc13783, MC13783_REG_RTC_DAY, days); > > + > > + return 0; > > +} > > + > > +static int mc13783_rtc_read_time(struct device *dev, struct rtc_time *tm) > > +{ > > + struct mc13783_rtc *priv = dev_get_drvdata(dev); > > + unsigned int seconds, days1, days2; > > + unsigned long s1970; > > + > > + rtc_tm_to_time(tm, &s1970); > > + > > + do { > > + mc13783_reg_read(priv->mc13783, MC13783_REG_RTC_TIME, &seconds); > > + mc13783_reg_read(priv->mc13783, MC13783_REG_RTC_DAY, &days1); > > + mc13783_reg_read(priv->mc13783, MC13783_REG_RTC_DAY, &days2); > > + } while (days1 != days2); > > + > > + s1970 = days1 * 86400 + seconds; > > + > > + rtc_time_to_tm(s1970, tm); > > + > > + return 0; > > use rtc_valid_tm > > > +} > > + > > +static const struct rtc_class_ops mc13783_rtc_ops = { > > + .read_time = mc13783_rtc_read_time, > > + .set_time = mc13783_rtc_set_time, > > +}; > > + > > +static int mc13783_rtc_probe(struct platform_device *pdev) > > +{ > > + int err; > > + struct mc13783_rtc *priv; > > + > > + priv = kzalloc(sizeof *priv, GFP_KERNEL); > > + if (!priv) > > + return -ENOMEM; > > + > > + priv->mc13783 = pdev->dev.platform_data; > > + platform_set_drvdata(pdev, priv); > > + > > + priv->rtc = rtc_device_register(pdev->name, > > + &pdev->dev, &mc13783_rtc_ops, THIS_MODULE); > > + > > + if (IS_ERR(priv->rtc)) { > > + err = PTR_ERR(priv->rtc); > > + goto exit_kfree; > > + } > > + > > + return 0; > > + > > +exit_kfree: > > + kfree(priv); > > + return err; > > +} > > + > > +static int __exit mc13783_rtc_remove(struct platform_device *pdev) > > +{ > > + struct mc13783_rtc *priv = platform_get_drvdata(pdev); > > + > > + rtc_device_unregister(priv->rtc); > > + platform_set_drvdata(pdev, NULL); > > + > > + kfree(priv); > > + > > + return 0; > > +} > > + > > +static struct platform_driver mc13783_rtc_driver = { > > + .probe = mc13783_rtc_probe, > > + .remove = __exit_p(mc13783_rtc_remove), > > + .driver = { > > + .name = "mc13783-rtc", > > + .owner = THIS_MODULE, > > + }, > > +}; > > + > > +static int __init mc13783_rtc_init(void) > > +{ > > + return platform_driver_register(&mc13783_rtc_driver); > > can you use platform_driver_probe? > > > +} > > +module_init(mc13783_rtc_init); > > + > > +static void __exit mc13783_rtc_exit(void) > > +{ > > + platform_driver_unregister(&mc13783_rtc_driver); > > +} > > +module_exit(mc13783_rtc_exit); > > + > > + > > +MODULE_AUTHOR("Sascha Hauer"); > > email here please. > > > +MODULE_DESCRIPTION("RTC driver for Freescale MC13783 PMIC"); > > +MODULE_LICENSE("GPL"); > > -- > > 1.6.3.3 > > > > > -- > > Best regards, > > Alessandro Zummo, > Tower Technologies - Torino, Italy > > http://www.towertech.it > > -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |