From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Sascha Hauer <s.hauer@pengutronix.de>
Cc: linux-kernel@vger.kernel.org,
Eric Piel <eric.piel@tremplin-utc.net>,
Luotao Fu <l.fu@pengutronix.de>,
lm-sensors@lm-sensors.org, Hans de Goede <hdegoede@redhat.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.arm.linux.org.uk
Subject: Re: [lm-sensors] [PATCH 3/5] [hwmon] add Freescale MC13783 adc driver
Date: Wed, 12 Aug 2009 17:42:53 +0100 [thread overview]
Message-ID: <20090812164252.GE11227@sirena.org.uk> (raw)
In-Reply-To: <1250089531-10399-4-git-send-email-s.hauer@pengutronix.de>
On Wed, Aug 12, 2009 at 05:05:29PM +0200, Sascha Hauer wrote:
> ---
> drivers/hwmon/Kconfig | 6 ++
> drivers/hwmon/Makefile | 1 +
> drivers/hwmon/mc13783-adc.c | 181 +++++++++++++++++++++++++++++++++++++++++++
Ideally there should be a Documentation/hwmon describing the chip and
the hwmon features it has.
> + for (i = 0; i < entries; i++) {
> + ret = device_create_file(&pdev->dev,
> + &mc13783_adc_ctl[i].dev_attr);
> + if (ret) {
> + dev_err(&pdev->dev,
> + "device_create_file failed with %d.\n", ret);
> + goto out_err;
> + }
> + }
Could use sysfs_create_group() here.
next prev parent reply other threads:[~2009-08-12 16:42 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-12 15:05 [PATCH V2] Freescale MC13783 PMIC support Sascha Hauer
2009-08-12 15:05 ` [PATCH 1/5] drivers/mfd: Add Freescale MC13783 driver Sascha Hauer
2009-08-12 15:05 ` [PATCH 2/5] [input] add mc13783 touchscreen driver Sascha Hauer
2009-08-12 15:05 ` [PATCH 3/5] [hwmon] add Freescale MC13783 adc driver Sascha Hauer
2009-08-12 15:05 ` [PATCH 4/5] [RTC] Add Freescale MC13783 RTC driver Sascha Hauer
2009-08-12 15:05 ` [PATCH 5/5] [regulator] Add a Freescale MC13783 regulator driver Sascha Hauer
2009-08-13 10:57 ` Liam Girdwood
2009-08-13 11:21 ` Samuel Ortiz
2009-08-13 11:38 ` Liam Girdwood
2009-08-12 16:42 ` Mark Brown [this message]
2009-08-13 13:37 ` [lm-sensors] [PATCH 3/5] [hwmon] add Freescale MC13783 adc driver Sascha Hauer
2009-08-13 14:16 ` Mark Brown
2009-08-12 16:04 ` [PATCH 2/5] [input] add mc13783 touchscreen driver Dmitry Torokhov
2009-08-13 12:26 ` Sascha Hauer
2009-08-13 15:52 ` Dmitry Torokhov
2009-12-04 19:52 ` [PATCH] " Uwe Kleine-König
2009-12-12 7:42 ` Dmitry Torokhov
2009-12-15 10:10 ` Uwe Kleine-König
2009-12-15 16:45 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090812164252.GE11227@sirena.org.uk \
--to=broonie@opensource.wolfsonmicro.com \
--cc=akpm@linux-foundation.org \
--cc=eric.piel@tremplin-utc.net \
--cc=hdegoede@redhat.com \
--cc=l.fu@pengutronix.de \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=lm-sensors@lm-sensors.org \
--cc=s.hauer@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®