mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Miller <davem@davemloft.net>
To: jens.axboe@oracle.com
Cc: linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com
Subject: Re: inlined spinlocks on sparc64
Date: Thu, 13 Aug 2009 02:08:12 -0700 (PDT)	[thread overview]
Message-ID: <20090813.020812.251047996.davem@davemloft.net> (raw)
In-Reply-To: <20090813082058.GX12579@kernel.dk>

From: Jens Axboe <jens.axboe@oracle.com>
Date: Thu, 13 Aug 2009 10:20:58 +0200

> I deleted the original thread, so I can't reply there. Just a heads up
> on the spinlock inlining on sparc64. I decided to give your patches a
> shot, since one of my IO benchmarks here basically degenerates into a
> spinlock microbenchmark with > 50% time spent there (unlock part,
> according to perf). Some of that is surely caching effects, but still.
> 
> For this particular workload, I get a net improvement of about 3.5% with
> the inlined functions. Not bad.

Doesn't surprise me, any function call can result in a register
window spill onto the stack, and that's 128 bytes of writes.

Later when you leave the code path you have to refill that spilled
window and you get 128 bytes of reads for each one of those.

  reply	other threads:[~2009-08-13  9:08 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-13  8:20 Jens Axboe
2009-08-13  9:08 ` David Miller [this message]
2009-08-13 11:56   ` Jens Axboe
2009-08-13 17:08 ` Heiko Carstens

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090813.020812.251047996.davem@davemloft.net \
    --to=davem@davemloft.net \
    --cc=heiko.carstens@de.ibm.com \
    --cc=jens.axboe@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®