From: David Miller <davem@davemloft.net>
To: paul.moore@hp.com
Cc: eparis@redhat.com, linux-kernel@vger.kernel.org,
selinux@tycho.nsa.gov, netdev@vger.kernel.org,
linux-security-module@vger.kernel.org, sds@tycho.nsa.gov,
shemminger@linux-foundation.org, kees@ubuntu.com,
morgan@kernel.org, casey@schaufler-ca.com, dwalsh@redhat.com
Subject: Re: [PATCH 1/3] Networking: use CAP_NET_ADMIN when deciding to call request_module
Date: Thu, 13 Aug 2009 16:14:50 -0700 (PDT) [thread overview]
Message-ID: <20090813.161450.193138821.davem@davemloft.net> (raw)
In-Reply-To: <200908131445.37263.paul.moore@hp.com>
From: Paul Moore <paul.moore@hp.com>
Date: Thu, 13 Aug 2009 14:45:37 -0400
> On Thursday 13 August 2009 09:44:51 am Eric Paris wrote:
>> The networking code checks CAP_SYS_MODULE before using request_module() to
>> try to load a kernel module. While this seems reasonable it's actually
>> weakening system security since we have to allow CAP_SYS_MODULE for things
>> like /sbin/ip and bluetoothd which need to be able to trigger module loads.
>> CAP_SYS_MODULE actually grants those binaries the ability to directly load
>> any code into the kernel. We should instead be protecting modprobe and the
>> modules on disk, rather than granting random programs the ability to load
>> code directly into the kernel. Instead we are going to gate those
>> networking checks on CAP_NET_ADMIN which still limits them to root but
>> which does not grant those processes the ability to load arbitrary code
>> into the kernel.
>>
>> Signed-off-by: Eric Paris <eparis@redhat.com>
>
> Sounds and looks reasonable to me.
>
> Acked-by: Paul Moore <paul.moore@hp.com>
Looks fine to me:
Acked-by: David S. Miller <davem@davemloft.net>
next prev parent reply other threads:[~2009-08-13 23:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-13 13:44 Eric Paris
2009-08-13 13:44 ` [PATCH 2/3] security: introducing security_request_module Eric Paris
2009-08-13 14:03 ` Serge E. Hallyn
2009-08-13 15:28 ` Eric Paris
2009-08-13 17:54 ` Serge E. Hallyn
2009-08-13 18:19 ` Eric Paris
2009-08-13 18:31 ` Serge E. Hallyn
2009-08-13 18:40 ` Serge E. Hallyn
2009-08-13 13:45 ` [PATCH 3/3] SELinux: add selinux_kernel_module_request Eric Paris
2009-08-13 18:43 ` Serge E. Hallyn
2009-08-13 14:01 ` [PATCH 1/3] Networking: use CAP_NET_ADMIN when deciding to call request_module Serge E. Hallyn
2009-08-13 18:45 ` Paul Moore
2009-08-13 22:55 ` James Morris
2009-08-13 23:14 ` David Miller [this message]
2009-08-14 1:56 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090813.161450.193138821.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=casey@schaufler-ca.com \
--cc=dwalsh@redhat.com \
--cc=eparis@redhat.com \
--cc=kees@ubuntu.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-security-module@vger.kernel.org \
--cc=morgan@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=paul.moore@hp.com \
--cc=sds@tycho.nsa.gov \
--cc=selinux@tycho.nsa.gov \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®