From: David Miller <davem@davemloft.net>
To: mpm@selenic.com
Cc: Dongdong.deng@windriver.com, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, Bruce.Ashfield@windriver.com,
jason.wessel@windriver.com
Subject: Re: [PATCH] drivers/net: fixed drivers that support netpoll use ndo_start_xmit()
Date: Fri, 14 Aug 2009 16:32:32 -0700 (PDT) [thread overview]
Message-ID: <20090814.163232.234331420.davem@davemloft.net> (raw)
In-Reply-To: <1250264019.3807.1301.camel@calx>
From: Matt Mackall <mpm@selenic.com>
Date: Fri, 14 Aug 2009 10:33:39 -0500
> On Fri, 2009-08-14 at 13:12 +0800, DDD wrote:
>> The NETPOLL API requires that interrupts remain disabled in
>> netpoll_send_skb(). The use of spin_lock_irq() and spin_unlock_irq()
>> in the NETPOLL API callbacks causes the interrupts to get enabled and
>> can lead to kernel instability.
>>
>> The solution is to use spin_lock_irqsave() and spin_unlock_restore()
>> to prevent the irqs from getting enabled while in netpoll_send_skb().
...
>> Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com>
>> Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
>> Acked-by: Bruce Ashfield <bruce.ashfield@windriver.com>
>
> Acked-by: Matt Mackall <mpm@selenic.com>
Applied, thanks everyone.
> Perhaps we should also have a WARN_ONCE if start_xmit returns with
> interrupts enabled?
Probably a good idea.
next prev parent reply other threads:[~2009-08-14 23:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 5:12 DDD
2009-08-14 15:33 ` Matt Mackall
2009-08-14 23:32 ` David Miller [this message]
2009-08-18 5:59 ` DDD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090814.163232.234331420.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Bruce.Ashfield@windriver.com \
--cc=Dongdong.deng@windriver.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome