From: David VomLehn <dvomlehn@cisco.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org, greg@kroah.com
Subject: Re: [PATCH 1/2] Use kfifo to buffer USB generic serial writes
Date: Fri, 14 Aug 2009 14:45:03 -0700 [thread overview]
Message-ID: <20090814214503.GA9051@cuplxvomd02.corp.sa.net> (raw)
In-Reply-To: <20090814222039.0cc29713@lxorguk.ukuu.org.uk>
On Fri, Aug 14, 2009 at 10:20:39PM +0100, Alan Cox wrote:
> > + spin_lock_irqsave(&port->write_fifo_lock, flags);
> > + chars = __kfifo_len(port->write_fifo);
> > + spin_unlock_irqrestore(&port->write_fifo_lock, flags);
>
> Any reason for not using kfifo_len() ?
Nope. At one time there was a bit more code protected here and when I took it
out, I missed the opportunity to squash it down. I'll incorporate this with
any other changes that come in.
> Alan
prev parent reply other threads:[~2009-08-14 21:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 20:02 David VomLehn
2009-08-14 20:15 ` Greg KH
2009-08-14 21:20 ` Alan Cox
2009-08-14 21:45 ` David VomLehn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090814214503.GA9051@cuplxvomd02.corp.sa.net \
--to=dvomlehn@cisco.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®