From: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
To: "Robert P. J. Day" <rpjday@crashcourse.ca>
Cc: Jiri Slaby <jirislaby@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Make shr to divide by power of 2 (resend)
Date: Sat, 15 Aug 2009 17:26:53 +0300 [thread overview]
Message-ID: <20090815142652.GA7968@localdomain.by> (raw)
In-Reply-To: <alpine.LFD.2.00.0908150947260.14440@localhost>
[-- Attachment #1: Type: text/plain, Size: 625 bytes --]
On (08/15/09 09:49), Robert P. J. Day wrote:
> it does seem like a DIV_ROUND_UP would be better but perhaps another
> solution would be to define a meaningful macro name for that
> operation. if that conversion is going to be done regularly, a macro
> with an informative name might be in order. if it's a one-shot
> operation, though, not much point.
>
There are different shr/shl operations in bitblit.c. Like,
cur_height = vc->vc_font.height >> 1
cur_height = (vc->vc_font.height << 1)/3;
c |= c >> 1;
u32 idx = vc->vc_font.width >> 3;
etc.
So I don't think we really need a macros here.
Sergey
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 315 bytes --]
prev parent reply other threads:[~2009-08-15 14:30 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 13:43 Sergey Senozhatsky
2009-08-15 13:48 ` Jiri Slaby
2009-08-15 13:49 ` Robert P. J. Day
2009-08-15 14:12 ` Sergey Senozhatsky
2009-08-15 20:42 ` Jiri Slaby
2009-08-16 9:14 ` Sergey Senozhatsky
2009-08-17 7:15 ` Jiri Slaby
2009-08-17 7:31 ` Sergey Senozhatsky
2009-08-17 7:48 ` [PATCH 1/1] VIDEO: console, use DIV_ROUND_UP Jiri Slaby
2009-08-17 8:00 ` Sergey Senozhatsky
2009-08-17 8:00 ` Jiri Slaby
2009-08-17 8:08 ` Sergey Senozhatsky
2009-08-17 8:11 ` Jiri Slaby
2009-08-15 14:26 ` Sergey Senozhatsky [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090815142652.GA7968@localdomain.by \
--to=sergey.senozhatsky@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jirislaby@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rpjday@crashcourse.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®