From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754486AbZHPOXd (ORCPT ); Sun, 16 Aug 2009 10:23:33 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754328AbZHPOXc (ORCPT ); Sun, 16 Aug 2009 10:23:32 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:55026 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752298AbZHPOXb (ORCPT ); Sun, 16 Aug 2009 10:23:31 -0400 Date: Sun, 16 Aug 2009 10:23:31 -0400 From: Christoph Hellwig To: Mark Lord Cc: Christoph Hellwig , xfs@oss.sgi.com, linux-fsdevel@vger.kernel.org, linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, jens.axboe@oracle.com, IDE/ATA development list Subject: Re: [PATCH, RFC] xfs: batched discard support Message-ID: <20090816142331.GA4284@infradead.org> References: <20090816004705.GA7347@infradead.org> <4A876255.10606@rtr.ca> <4A876CA9.20906@rtr.ca> <20090816022500.GA12392@infradead.org> <4A8802F3.6010908@rtr.ca> <4A8810C4.3050800@rtr.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <4A8810C4.3050800@rtr.ca> User-Agent: Mutt/1.5.19 (2009-01-05) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Aug 16, 2009 at 09:59:32AM -0400, Mark Lord wrote: > Okay, I got Matthews patches updated onto 2.6.31, and fixed the incompatibilities > between those and the XFS TRIM patch (from Christoph), plus a sector_t printk issue. > > My apologies for attachments, but I am attaching the updated Christoph patch, > as well as my hacked-up forward-port of Matthew's patches. > > Not pretty, but they work. :) > > Now.. running Christoph's "xfs trim" on a 4.6GB mostly already-trimmed > XFS partition gave this for the first time around: > The problem is, it still issues TRIMs to the LLD one extent at a time. > Compare this with doing it all in a single TRIM command > with the wiper.sh script (filesystem unmounted): I could do a variant which issues a single TRIM, but that would require us to lock out all other allocations for the time the trim takes. I'll hack that up once I get some time.