From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755767AbZHPT2s (ORCPT ); Sun, 16 Aug 2009 15:28:48 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752220AbZHPT2r (ORCPT ); Sun, 16 Aug 2009 15:28:47 -0400 Received: from earthlight.etchedpixels.co.uk ([81.2.110.250]:42023 "EHLO www.etchedpixels.co.uk" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751292AbZHPT2q (ORCPT ); Sun, 16 Aug 2009 15:28:46 -0400 Date: Sun, 16 Aug 2009 20:29:05 +0100 From: Alan Cox To: Arjan van de Ven Cc: James Bottomley , Mark Lord , Chris Worley , Matthew Wilcox , Bryan Donlan , david@lang.hm, Greg Freemyer , Markus Trippelsdorf , Matthew Wilcox , Hugh Dickins , Nitin Gupta , Ingo Molnar , Peter Zijlstra , linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-scsi@vger.kernel.org, linux-ide@vger.kernel.org, Linux RAID Subject: Re: Discard support (was Re: [PATCH] swap: send callback when swap slot is freed) Message-ID: <20090816202905.59efa611@lxorguk.ukuu.org.uk> In-Reply-To: <20090816083434.2ce69859@infradead.org> References: <200908122007.43522.ngupta@vflare.org> <20090813151312.GA13559@linux.intel.com> <20090813162621.GB1915@phenom2.trippelsdorf.de> <87f94c370908131115r680a7523w3cdbc78b9e82373c@mail.gmail.com> <3e8340490908131354q167840fcv124ec56c92bbb830@mail.gmail.com> <4A85E0DC.9040101@rtr.ca> <20090814234539.GE27148@parisc-linux.org> <1250341176.4159.2.camel@mulgrave.site> <4A86B69C.7090001@rtr.ca> <1250344518.4159.4.camel@mulgrave.site> <20090816150530.2bae6d1f@lxorguk.ukuu.org.uk> <20090816083434.2ce69859@infradead.org> X-Mailer: Claws Mail 3.7.1 (GTK+ 2.14.7; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > trim is mostly for ssd's though, and those tend to not have the "goes > for a hike" behavior as much...... Bench one. > I wonder if it's worse to batch stuff up, because then the trim itself > gets bigger and might take longer..... They seem to implement a sort of async single threaded trim, which can only have one outstanding trim at a time.