From: Eric Paris <eparis@redhat.com>
To: linux-kernel@vger.kernel.org, fs-devel@vger.kernel.org
Cc: torvalds@linux-foundation.org, viro@ZenIV.linux.org.uk
Subject: [PATCH 2/3] inotify: tail drop inotify q_overflow events
Date: Sun, 16 Aug 2009 21:51:49 -0400 [thread overview]
Message-ID: <20090817015149.15099.12171.stgit@paris.rdu.redhat.com> (raw)
In-Reply-To: <20090817015143.15099.80614.stgit@paris.rdu.redhat.com>
In f44aebcc the tail drop logic of events with no file backing
(q_overflow and in_ignored) was reversed so IN_IGNORED events would never
be tail dropped. This now means that Q_OVERFLOW events are NOT tail
dropped. The fix is to not tail drop IN_IGNORED, but to tail drop
Q_OVERFLOW.
Signed-off-by: Eric Paris <eparis@redhat.com>
---
fs/notify/notification.c | 4 ++++
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/fs/notify/notification.c b/fs/notify/notification.c
index 74b3cf3..3816d57 100644
--- a/fs/notify/notification.c
+++ b/fs/notify/notification.c
@@ -153,6 +153,10 @@ static bool event_compare(struct fsnotify_event *old, struct fsnotify_event *new
return true;
break;
case (FSNOTIFY_EVENT_NONE):
+ if (old->mask & FS_Q_OVERFLOW)
+ return true;
+ else if (old->mask & FS_IN_IGNORED)
+ return false;
return false;
};
}
next prev parent reply other threads:[~2009-08-17 1:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-17 1:51 [PATCH 1/3] notify: unused event private race Eric Paris
2009-08-17 1:51 ` Eric Paris [this message]
2009-08-17 1:51 ` [PATCH 3/3] inotify: start watch descriptor count at 1 Eric Paris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090817015149.15099.12171.stgit@paris.rdu.redhat.com \
--to=eparis@redhat.com \
--cc=fs-devel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®