From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758617AbZHRKPj (ORCPT ); Tue, 18 Aug 2009 06:15:39 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753720AbZHRKPi (ORCPT ); Tue, 18 Aug 2009 06:15:38 -0400 Received: from mx2.mail.elte.hu ([157.181.151.9]:40718 "EHLO mx2.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751994AbZHRKPh (ORCPT ); Tue, 18 Aug 2009 06:15:37 -0400 Date: Tue, 18 Aug 2009 12:15:25 +0200 From: Ingo Molnar To: Mark Kelly Cc: "H. Peter Anvin" , Andi Kleen , linux-kernel@vger.kernel.org, Florian Fainelli , Thomas Gleixner Subject: Re: [patch, v2] x86: CPU detection for RDC Message-ID: <20090818101525.GB14374@elte.hu> References: <20090816175204.GA28553@elte.hu> <4A899A1D.8060808@zytor.com> <20090817180825.GA5558@elte.hu> <4A899FEA.9020707@zytor.com> <871vnas2gn.fsf@basil.nowhere.org> <4A89A724.406@zytor.com> <20090817213118.GA24747@one.firstfloor.org> <4A89D300.5030509@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) X-ELTE-SpamScore: -1.1 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.1 required=5.9 tests=BAYES_05 autolearn=no SpamAssassin version=3.2.5 -1.1 BAYES_05 BODY: Bayesian spam probability is 1 to 5% [score: 0.0127] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Mark Kelly wrote: > --- a/arch/x86/Kconfig > +++ b/arch/x86/Kconfig > @@ -382,6 +382,7 @@ config X86_RDC321X > bool "RDC R-321x SoC" > depends on X86_32 > depends on X86_EXTENDED_PLATFORM > + select PCI > select M486 > select X86_REBOOTFIXUPS PCI is a complex interactive Kconfig switch and we dont select it in x86 code. Please add a 'depends on PCI' line instead, as i suggested in my mail. Ingo