From: David Miller <davem@davemloft.net>
To: khc@pm.waw.pl
Cc: walt@holmansrus.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: Strange network timeouts w/ 2.6.30.5
Date: Thu, 20 Aug 2009 12:28:50 -0700 (PDT) [thread overview]
Message-ID: <20090820.122850.37712606.davem@davemloft.net> (raw)
In-Reply-To: <m3skfmk39q.fsf@intrepid.localdomain>
From: Krzysztof Halasa <khc@pm.waw.pl>
Date: Thu, 20 Aug 2009 15:45:21 +0200
> Something like maybe:
>
> Signed-off-by: Krzysztof Hałasa <khc@pm.waw.pl>
>
> diff --git a/drivers/net/e100.c b/drivers/net/e100.c
> index 014dfb6..b610088 100644
> --- a/drivers/net/e100.c
> +++ b/drivers/net/e100.c
> @@ -1762,9 +1762,12 @@ static int e100_rx_indicate(struct nic *nic, struct rx *rx,
>
> if (ioread8(&nic->csr->scb.status) & rus_no_res)
> nic->ru_running = RU_SUSPENDED;
> +#ifndef CONFIG_X86
> + /* FIXME interferes with swiotlb. */
> pci_dma_sync_single_for_device(nic->pdev, rx->dma_addr,
> sizeof(struct rfd),
> PCI_DMA_BIDIRECTIONAL);
> +#endif
> return -ENODATA;
> }
>
I'm not willing to apply something like this.
swiotlb emulates what hardware does, so if it can go wrong with
swiotlb it can go wrong with hardware to.
Figure out what the exact bug is.
next prev parent reply other threads:[~2009-08-20 19:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1359163732.51250769223038.JavaMail.root@mail.holmansrus.com>
2009-08-20 11:54 ` Walt Holman
2009-08-20 13:45 ` Krzysztof Halasa
2009-08-20 19:28 ` David Miller [this message]
2009-08-20 20:28 ` Krzysztof Halasa
2009-08-20 22:21 ` Walt Holman
2009-08-21 9:44 ` Krzysztof Halasa
2009-08-23 19:18 ` Aviv Greenberg
2009-08-23 20:02 ` Krzysztof Halasa
[not found] <1489093361.01250869377567.JavaMail.root@mail.holmansrus.com>
2009-08-21 15:45 ` Walt Holman
2009-08-22 20:26 ` Krzysztof Halasa
[not found] <1762204735.01250727555803.JavaMail.root@mail.holmansrus.com>
2009-08-20 0:21 ` Walt Holman
2009-08-20 4:17 ` David Miller
2009-08-20 9:03 ` Krzysztof Halasa
2009-08-20 9:13 ` David Miller
2009-08-20 9:22 ` Krzysztof Halasa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090820.122850.37712606.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=walt@holmansrus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome