mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Christoph Thielecke <christoph.thielecke@gmx.de>
To: Eric Paris <eparis@redhat.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: kernel bug 2.6.31-rc6 (2)
Date: Thu, 20 Aug 2009 07:48:49 +0200	[thread overview]
Message-ID: <200908200748.52348.christoph.thielecke@gmx.de> (raw)
In-Reply-To: <1250720787.4198.2.camel@dhcp231-106.rdu.redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1533 bytes --]

Hello Eric,

> On Wed, 2009-08-19 at 14:48 +0200, Christoph Thielecke wrote:
> > Aug 19 14:05:03 develop kernel: kernel BUG at
> > fs/notify/inotify/inotify_fsnotify.c:109!
>
> Can you apply the following patch?  It cleans up some logic, which I
> didn't see a problem with, but it makes it very easy for me to know it's
> right now.  It also should prevent the BUG() you hit from bringing down
> the box.

> commit da9d447e409fdca12001378650f020982093e91e
> Author: Eric Paris <eparis@redhat.com>
> Date:   Wed Aug 19 17:01:12 2009 -0400
>
>     inotify: the inotify add watch code is horrible clean it up
>
>     Just reworking the inotify watch add code to be readable, clean, and
> full of a lot less gotos.
>
>     Signed-off-by: Eric Paris <eparis@redhat.com>
>
> diff --git a/fs/notify/inotify/inotify_fsnotify.c
> b/fs/notify/inotify/inotify_fsnotify.c index d11ac71..1df198b 100644

The patch does not apply clean:

develop:/usr/src/linux-2.6.git.linus# patch -p1 
< /home/crissi/download2/inotify_fsnotify_test.patch
patching file fs/notify/inotify/inotify_fsnotify.c
Hunk #1 succeeded at 107 (offset -72 lines).
patching file fs/notify/inotify/inotify_user.c
Hunk #1 FAILED at 431.

Is it against 2.6.31-rc6 or current git? I have 2.6.31-rc6-00195-gc124891.
I did an update to latest from linus and try to apply your patch but it fails 
there too (no changes in the files after update from git).


Best regards

Christoph
-- 
Linux User Group Wernigerode
http://www.lug-wr.de/

[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2009-08-20  5:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-19 12:48 Christoph Thielecke
2009-08-19 13:47 ` Eric Paris
2009-08-19 22:26 ` Eric Paris
2009-08-20  5:48   ` Christoph Thielecke [this message]
2009-08-20 14:24     ` Eric Paris

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908200748.52348.christoph.thielecke@gmx.de \
    --to=christoph.thielecke@gmx.de \
    --cc=eparis@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®