mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Jeremy Fitzhardinge <jeremy@goop.org>,
	Arjan van de Ven <arjan@infradead.org>,
	"H. Peter Anvin" <hpa@zytor.com>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	the arch/x86 maintainers <x86@kernel.org>
Subject: Re: [GIT PULL] Fix Xen boot with CONFIG_CC_STACKPROTECTOR
Date: Thu, 20 Aug 2009 12:06:44 +0200	[thread overview]
Message-ID: <20090820100644.GC29093@elte.hu> (raw)
In-Reply-To: <4A8C98DD.2020709@goop.org>


* Jeremy Fitzhardinge <jeremy@goop.org> wrote:

> Hi Ingo,
> 
> Here's a couple of little changes which prevents an early boot crash
> under Xen, due to the stackprotector preamble using segment registers
> before they're set up.  I only need to disable stackprotector for a
> handful of functions, but unfortunately it looks like it can only be
> disabled on a per-file basis.
> 
> Thanks,
>     J
> 
> The following changes since commit 64f1607ffbbc772685733ea63e6f7f4183df1b16:
>   Linus Torvalds (1):
>         Linux 2.6.31-rc6
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/jeremy/xen.git bugfix
> 
> Jeremy Fitzhardinge (2):
>       x86: make sure load_percpu_segment has no stackprotector
>       xen: rearrange things to fix stackprotector
> 
>  arch/x86/kernel/cpu/Makefile |    4 ++++
>  arch/x86/xen/Makefile        |    4 ++++
>  arch/x86/xen/enlighten.c     |   22 ++++++++++------------
>  3 files changed, 18 insertions(+), 12 deletions(-)

Pulled into tip:x86/urgent, thanks a lot Jeremy!

Btw., is there any way to turn off stackprotector on a 
per function basis, a GCC attribute perhaps? That would 
be preferable to turning it off for all of common.o.

	Ingo

  reply	other threads:[~2009-08-20 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-20  0:29 Jeremy Fitzhardinge
2009-08-20 10:06 ` Ingo Molnar [this message]
2009-08-20 16:00   ` H. Peter Anvin
2009-08-20 16:24   ` Jeremy Fitzhardinge
2009-08-21  8:27     ` Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090820100644.GC29093@elte.hu \
    --to=mingo@elte.hu \
    --cc=arjan@infradead.org \
    --cc=hpa@zytor.com \
    --cc=jeremy@goop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome