Re: [PATCH] Samsung laptop driver

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Fri, 21 Aug 2009 15:59:25 -0700
Greg KH <greg@kroah.com> wrote:
> Jesse, I don't know how this is going to play with your recently added
> backlight support for the i915 driver.  As you don't have control over
> the LEDs and other stuff that this driver is going to support, I think
> we need some way to keep the i915 driver from messing with the
> backlight values, don't you think?

Right, it should be fine.  The i915 driver should only take control and
provide a backlight when:
  - no ACPI method is available
  - no platform method is available (like this one)
  - backlight is exposed through the GPU or i2c

So I'm a lot happier now that you've figured out the proper platform
interface. :)  The test code I sent out earlier didn't work for Mike
because his VBIOS (properly it turns out) indicated that there was an
external agent in charge of the backlight.

Thanks,
-- 
Jesse Barnes, Intel Open Source Technology Center