From: David Miller <davem@davemloft.net>
To: Dongdong.deng@windriver.com
Cc: nico@cam.org, mpm@selenic.com, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, jason.wessel@windriver.com
Subject: Re: [PATCH] [net] smc91x: let smc91x work well under netpoll
Date: Sun, 23 Aug 2009 22:59:12 -0700 (PDT) [thread overview]
Message-ID: <20090823.225912.87554943.davem@davemloft.net> (raw)
In-Reply-To: <1251085351.6588.21.camel@dengdd-desktop>
From: DDD <Dongdong.deng@windriver.com>
Date: Mon, 24 Aug 2009 11:42:31 +0800
> The NETPOLL requires that interrupts remain disabled in its callbacks.
>
> Using *_irq_save()/irq_restore() to replace *_irq_disable()/irq_enable()
> functions in NETPOLL's callbacks of smc91x, so that it doesn't enable
> interrupts when already disabled, and kgdboe/netconsole would work
> properly over smc91x.
>
> Signed-off-by: Dongdong Deng <dongdong.deng@windriver.com>
> Acked-by: Nicolas Pitre <nico@cam.org>
Applied, thanks.
next prev parent reply other threads:[~2009-08-24 5:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-21 13:33 [PATCH 1/2] netpoll: warning for ndo_start_xmit returns with interrupts enabled DDD
2009-08-21 13:34 ` [PATCH 2/2] drivers/net: fixed drivers that support netpoll use ndo_start_xmit() DDD
2009-08-21 15:26 ` Matt Mackall
2009-08-24 2:50 ` David Miller
2009-08-21 13:40 ` [RFC][PATCH] smc91x: let smc91x work well with netpoll DDD
2009-08-21 17:13 ` Nicolas Pitre
2009-08-24 3:42 ` [PATCH] [net] smc91x: let smc91x work well under netpoll DDD
2009-08-24 5:59 ` David Miller [this message]
2009-08-24 2:50 ` [PATCH 1/2] netpoll: warning for ndo_start_xmit returns with interrupts enabled David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090823.225912.87554943.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=Dongdong.deng@windriver.com \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=netdev@vger.kernel.org \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®