From: Jesse Barnes <jbarnes@virtuousgeek.org>
To: Yinghai Lu <yinghai@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-pci@vger.kernel.org" <linux-pci@vger.kernel.org>,
Suresh Siddha <suresh.b.siddha@intel.com>
Subject: Re: [PATCH] pci/intr_remapping: allocate irq_iommu on node -v3
Date: Tue, 25 Aug 2009 11:48:59 -0700 [thread overview]
Message-ID: <20090825114859.777be874@jbarnes-g45> (raw)
In-Reply-To: <4A84C21A.4000705@kernel.org>
Ingo, I assume you took these two?
Thanks,
Jesse
On Thu, 13 Aug 2009 18:47:06 -0700
Yinghai Lu <yinghai@kernel.org> wrote:
>
> make it use node from irq_desc.
> v3: use irq_node
>
> Signed-off-by: Yinghai Lu <yinghai@kernel.org>
>
> ---
> drivers/pci/intr_remapping.c | 14 +++-----------
> 1 file changed, 3 insertions(+), 11 deletions(-)
>
> Index: linux-2.6/drivers/pci/intr_remapping.c
> ===================================================================
> --- linux-2.6.orig/drivers/pci/intr_remapping.c
> +++ linux-2.6/drivers/pci/intr_remapping.c
> @@ -55,15 +55,12 @@ static struct irq_2_iommu *irq_2_iommu(u
> return desc->irq_2_iommu;
> }
>
> -static struct irq_2_iommu *irq_2_iommu_alloc_node(unsigned int irq,
> int node) +static struct irq_2_iommu *irq_2_iommu_alloc(unsigned int
> irq) {
> struct irq_desc *desc;
> struct irq_2_iommu *irq_iommu;
>
> - /*
> - * alloc irq desc if not allocated already.
> - */
> - desc = irq_to_desc_alloc_node(irq, node);
> + desc = irq_to_desc(irq);
> if (!desc) {
> printk(KERN_INFO "can not get irq_desc for %d\n",
> irq); return NULL;
> @@ -72,16 +69,11 @@ static struct irq_2_iommu *irq_2_iommu_a
> irq_iommu = desc->irq_2_iommu;
>
> if (!irq_iommu)
> - desc->irq_2_iommu = get_one_free_irq_2_iommu(node);
> + desc->irq_2_iommu =
> get_one_free_irq_2_iommu(irq_node(irq));
> return desc->irq_2_iommu;
> }
>
> -static struct irq_2_iommu *irq_2_iommu_alloc(unsigned int irq)
> -{
> - return irq_2_iommu_alloc_node(irq, cpu_to_node(boot_cpu_id));
> -}
> -
> #else /* !CONFIG_SPARSE_IRQ */
>
> static struct irq_2_iommu irq_2_iommuX[NR_IRQS];
>
--
Jesse Barnes, Intel Open Source Technology Center
next prev parent reply other threads:[~2009-08-25 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-14 1:43 [PATCH] irq: make sure irq_desc for legacy irq get correct node setting Yinghai Lu
2009-08-14 1:44 ` [PATCH] irq: add irq_node Yinghai Lu
2009-08-14 1:47 ` [PATCH] pci/intr_remapping: allocate irq_iommu on node -v3 Yinghai Lu
2009-08-25 18:48 ` Jesse Barnes [this message]
2009-08-26 7:31 ` Ingo Molnar
2009-08-26 16:42 ` Jesse Barnes
[not found] <20090826214323.GC25536@elte.hu>
2009-08-26 23:20 ` [PATCH] irq: make sure irq_desc for legacy irq get correct node setting Yinghai Lu
2009-08-26 23:20 ` [PATCH] irq: add irq_node Yinghai Lu
2009-08-26 23:21 ` [PATCH] pci/intr_remapping: allocate irq_iommu on node -v3 Yinghai Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090825114859.777be874@jbarnes-g45 \
--to=jbarnes@virtuousgeek.org \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
--cc=yinghai@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®