mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Cyrill Gorcunov <gorcunov@openvz.org>
Cc: x86@kernel.org, linux-kernel@vger.kernel.org,
	"Maciej W. Rozycki" <macro@linux-mips.org>
Subject: Re: [rfc -tip 3/4] x86,apic: fix missed handling of discrete apics
Date: Wed, 26 Aug 2009 08:12:41 +0200	[thread overview]
Message-ID: <20090826061241.GC6194@elte.hu> (raw)
In-Reply-To: <20090824175551.322214127@openvz.org>


* Cyrill Gorcunov <gorcunov@openvz.org> wrote:

> +	if (!cpu_has_apic && (!smp_found_config || disable_apic))
> +	if (!cpu_has_apic && (!smp_found_config || disable_apic))
> +	if (cpu_has_apic || (smp_found_config && !disable_apic))

these are now repeating patterns, so that should be moved into a 
helper inline or so.

	Ingo

  reply	other threads:[~2009-08-26  6:12 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-24 17:53 [rfc -tip 0/4] x86 apic,ioapic fixes Cyrill Gorcunov
2009-08-24 17:53 ` [rfc -tip 1/4] x86,ioapic: define IO_APIC_DEFAULT_PHYS_BASE constant Cyrill Gorcunov
2009-08-26  6:22   ` [tip:x86/apic] x86, ioapic: Define " tip-bot for Cyrill Gorcunov
2009-08-24 17:53 ` [rfc -tip 2/4] x86,e820: __e820_add_region -- guard against array overflowed Cyrill Gorcunov
2009-08-26  6:22   ` [tip:x86/setup] x86, e820: Guard against array overflowed in __e820_add_region() tip-bot for Cyrill Gorcunov
2009-08-24 17:53 ` [rfc -tip 3/4] x86,apic: fix missed handling of discrete apics Cyrill Gorcunov
2009-08-26  6:12   ` Ingo Molnar [this message]
2009-08-26  6:22     ` Cyrill Gorcunov
2009-08-26 16:49     ` Cyrill Gorcunov
2009-08-24 17:53 ` [rfc -tip 4/4] x86,ioapic: ioapic_setup_resources - get rid of needless check and simplify Cyrill Gorcunov
2009-08-26  6:22   ` [tip:x86/apic] x86, ioapic: Get rid of needless check and simplify ioapic_setup_resources() tip-bot for Cyrill Gorcunov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090826061241.GC6194@elte.hu \
    --to=mingo@elte.hu \
    --cc=gorcunov@openvz.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=macro@linux-mips.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome