From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbZH1Opn (ORCPT ); Fri, 28 Aug 2009 10:45:43 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751521AbZH1Opm (ORCPT ); Fri, 28 Aug 2009 10:45:42 -0400 Received: from e28smtp09.in.ibm.com ([59.145.155.9]:52363 "EHLO e28smtp09.in.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751422AbZH1Opm (ORCPT ); Fri, 28 Aug 2009 10:45:42 -0400 Date: Fri, 28 Aug 2009 20:15:39 +0530 From: Balbir Singh To: KAMEZAWA Hiroyuki Cc: "linux-mm@kvack.org" , "linux-kernel@vger.kernel.org" , "nishimura@mxp.nes.nec.co.jp" Subject: Re: [RFC][PATCH 1/5] memcg: change for softlimit. Message-ID: <20090828144539.GN4889@balbir.in.ibm.com> Reply-To: balbir@linux.vnet.ibm.com References: <20090828132015.10a42e40.kamezawa.hiroyu@jp.fujitsu.com> <20090828132321.e4a497bb.kamezawa.hiroyu@jp.fujitsu.com> <20090828072007.GH4889@balbir.in.ibm.com> <20090828163523.e51678be.kamezawa.hiroyu@jp.fujitsu.com> <20090828132643.GM4889@balbir.in.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * KAMEZAWA Hiroyuki [2009-08-28 23:29:09]: > Balbir Singh wrote: > > * KAMEZAWA Hiroyuki [2009-08-28 > > 16:35:23]: > > > > >> > >> Current soft-limit RB-tree will be easily broken i.e. not-sorted > >> correctly > >> if used under use_hierarchy=1. > >> > > > > Not true, I think the sorted-ness is delayed and is seen when we pick > > a tree for reclaim. Think of it as being lazy :) > > > plz explain how enexpectedly unsorted RB-tree can work sanely. > > There are two checks built-in 1. In the reclaim path (we see how much to reclaim, compared to the soft limit) 2. In the dequeue path where we check if we really are over soft limit I did lot of testing with the time based approach and found no broken cases, I;ve been testing it with the mmotm (event based approach and I am yet to see a broken case so far). -- Balbir