mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonas Meurer <jonas@freesources.org>
To: Sebastian Andrzej Siewior <sebastian@ml.breakpoint.cc>
Cc: Celejar <celejar@gmail.com>,
	Randy Dunlap <randy.dunlap@oracle.com>,
	541835@bugs.debian.org, lkml <linux-kernel@vger.kernel.org>,
	linux-crypto@vger.kernel.org
Subject: Re: [pkg-cryptsetup-devel] Bug#541835: crypto configuration / dependencies broken
Date: Mon, 31 Aug 2009 17:52:00 +0200	[thread overview]
Message-ID: <20090831155200.GD7678@resivo.wgnet.de> (raw)
In-Reply-To: <20090830153722.GA28497@Chamillionaire.breakpoint.cc>

hey,

On 30/08/2009 Sebastian Andrzej Siewior wrote:
> * Sebastian Andrzej Siewior | 2009-08-28 10:00:56 [+0200]:
> 
> >>> the problem is not reproducible with a debian/unstable 2.6.30.6 kernel,
> >>> even though it has cbc compiled as module as well. but if I recompile
> >>> the same kernel sources with Celejars kernel .config, the problem
> >>> occurs. thus it must be related to the kernel config in some way.
> >It must be the kernel confing since I run .30.stable and it works. I try
> >to look at it later.
> 
> Your kernel config is fine, the problem is that the initramfs tools do
> not copy all of the required modules into the initramfs. The missing
> modles are:
> - cryptomgr: that one is responsible to load the cbc and aes module and
>   bind them to cbc(aes)
> - chainiv: that one creates IVs if the "user" does not specify one.
>   dm-crypt probably does not use that one but is required due to the way
>   crypto works atm.
> - krng: provides random numbers and is required by chainiv.
> 
> If you add those three to /etc/initramfs/modules than it should work.
> 
> Could someone please look at initramfs to figure out why those three
> modules are not copied in this reduced setup?

the reason is simply that no other crypto modules define depends on the
listed ones:

# modinfo -F depends dm-crypt
dm-mod,crypto_blkcipher

# modinfo -F aes_generic sha256_generic cbc
crypto_algapi
crypto_hash
crypto_algapi,crypto_blkcipher

# modinfo -F crypto_blkcipher crypto_hash
crypto_algapi
crypto_algapi

and even the new modules don't depend on each other:

# modinfo -F cryptomgr
crypto_hash,crypto_algapi,crypto_blkcipher,aead,pcompress

# modinfo -F chainiv
crypto_algapi,rng,crypto_wq,crypto_blkcipher

# modinfo -F krng
rng,crypto_algapi

so the following depends should be added/changed:

- chainiv should depend o 'krng' instead of 'rng' at least
- maybe cipher modules like aes,serpent,... should depend on 'cryptomgr'
  instead of 'crypto_algapi'
- crypto_algapi should depend on chainiv

these changes are pure guesses, i don't know the details. but at least
additional depends need to be defined for crypto modules, don't you
think so?

greetings,
 jonas

  parent reply	other threads:[~2009-08-31 15:52 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-25 23:58 Celejar
2009-08-27 16:55 ` Randy Dunlap
2009-08-27 18:35   ` [pkg-cryptsetup-devel] Bug#541835: " Jonas Meurer
2009-08-27 19:34     ` Randy Dunlap
2009-08-28  8:00       ` Sebastian Andrzej Siewior
2009-08-30 15:37         ` Sebastian Andrzej Siewior
2009-08-31  0:06           ` Celejar
2009-08-31 15:52           ` Jonas Meurer [this message]
2009-08-31 21:16             ` Sebastian Andrzej Siewior
2009-09-01  0:51               ` Jonas Meurer
2009-09-01 21:11                 ` Sebastian Andrzej Siewior
2009-09-03  3:22                 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090831155200.GD7678@resivo.wgnet.de \
    --to=jonas@freesources.org \
    --cc=541835@bugs.debian.org \
    --cc=celejar@gmail.com \
    --cc=linux-crypto@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sebastian@ml.breakpoint.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®