mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alexey Dobriyan <adobriyan@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Stefani Seibold <stefani@seibold.net>,
	Christoph Hellwig <hch@infradead.org>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH] Fix proc_file_write missing ppos update
Date: Mon, 31 Aug 2009 21:19:56 +0400	[thread overview]
Message-ID: <20090831171956.GA3036@x200.localdomain> (raw)
In-Reply-To: <200908311744.52972.arnd@arndb.de>

On Mon, Aug 31, 2009 at 05:44:52PM +0200, Arnd Bergmann wrote:
> On Monday 31 August 2009, Alexey Dobriyan wrote:
> > Out-of-tree argument means almost nothing.
> > 
> > ...
> >
> > You'd better start converting to struct file_operations::write now.
> 
> Maybe a purely mechanical conversion to file_operations would be a nice first
> step, just so we can remove read_proc and write_proc? Taking scsi_proc.c
> as an example, this should be really straightforward and lets us get
> rid of the write_proc and read_proc callbacks from proc_dir_entry without
> having to rewrite all the remaining drivers that use it.
> 
> Obviously, someone who understands the specific driver code better should
> then clean up the code by converting to seq_file operations or something
> else that is appropriate there.

I don't like any churn in that area. Everything is ready for ->proc_fops usage.
So we should simply convert users away.
Actually most of SCSI and IDE is already done, just wasn't sent yet.

After conversion, ->read_proc, ->write_proc, create_proc_read_entry(),
create_proc_entry() will become deprecated for a while, then gone.

  reply	other threads:[~2009-08-31 17:19 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-29 16:38 Stefani Seibold
2009-08-29 23:16 ` Christoph Hellwig
2009-08-30  8:09   ` Alexey Dobriyan
2009-08-30 19:10     ` Stefani Seibold
2009-08-30 19:05   ` Stefani Seibold
2009-08-31  6:33     ` Alexey Dobriyan
2009-08-31 15:44       ` Arnd Bergmann
2009-08-31 17:19         ` Alexey Dobriyan [this message]
2009-08-31 17:21           ` Christoph Hellwig
2009-08-31 20:19           ` Arnd Bergmann
2009-09-12 15:28     ` Al Viro
2009-09-12 15:57       ` Stefani Seibold
2009-09-12 20:51         ` Eric W. Biederman
  -- strict thread matches above, loose matches on Subject: below --
2009-08-07 20:27 Stefani Seibold
2009-08-07 20:58 ` Andrew Morton
2009-08-07 21:43   ` Stefani Seibold
2009-08-07 22:16     ` Andrew Morton
2009-08-08  6:59       ` Eric W. Biederman
2009-08-08  9:29         ` Stefani Seibold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090831171956.GA3036@x200.localdomain \
    --to=adobriyan@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=arnd@arndb.de \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stefani@seibold.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®