From: "George Spelvin" <linux@horizon.com>
To: linux@horizon.com, neilb@suse.de
Cc: david@lang.hm, linux-doc@vger.kernel.org,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
pavel@ucw.cz
Subject: Re: raid is dangerous but that's secret (was Re: [patch] ext2/3:
Date: 1 Sep 2009 07:18:03 -0400 [thread overview]
Message-ID: <20090901111803.11027.qmail@science.horizon.com> (raw)
In-Reply-To: <4a2c5faeb04cab59af9ba6ab512c9916.squirrel@neil.brown.name>
>> An embedded checksum, no matter how good, can't tell you if
>> the data is stale; you need a way to distinguish versions in the pointer.
> I would disagree with that.
> If the embedded checksum is a function of both the data and the address
> of the data (in whatever address space seems most appropriate) then it can
> still verify that the data found with the checksum is the data that was
> expected.
> And storing the checksum with the data (where it is practical) means
> index blocks can be more dense so on average fewer accesses to storage
> are needed.
I must not have been clear. Originally, block 100 has contents version 1.
This includes a correctly computed checksum.
Then you write version 2 of the data there. But there's a bit error in
the address and the write goes to block 256+100 = 356. So block
100 still has the version 1 contents, complete with valid checksum.
(Yes, block 356 is now corrupted, but perhaps it's not even allocated.)
Then we go to read block 100, find a valid checksum, and return incorrect
data. Namely, version 1 data, when we expact and want version 2.
Basically, the pointer has to say which *version* of the data it points to,
not just the block address. Otherwise, it can't detect a missing write.
If density is a big issue, then including a small version field is a
possibility.
next prev parent reply other threads:[~2009-09-01 11:18 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 0:54 George Spelvin
2009-08-31 11:04 ` Pavel Machek
2009-08-31 15:45 ` david
2009-09-01 0:56 ` George Spelvin
2009-09-01 8:36 ` NeilBrown
2009-09-01 8:46 ` Pavel Machek
2009-09-01 11:18 ` George Spelvin [this message]
2009-09-01 12:35 ` NeilBrown
2009-09-01 15:25 ` david
2009-09-01 21:12 ` NeilBrown
2009-09-01 16:18 ` Andreas Dilger
2009-09-02 1:10 ` George Spelvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090901111803.11027.qmail@science.horizon.com \
--to=linux@horizon.com \
--cc=david@lang.hm \
--cc=linux-doc@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®