From: Mark Brown <broonie@opensource.wolfsonmicro.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Liam Girdwood <lrg@slimlogic.co.uk>,
Samuel Ortiz <sameo@linux.intel.com>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Russell King <linux@arm.linux.org.uk>
Subject: Re: [PATCH 2/2] U300 AB3100 boardinfo v3
Date: Wed, 2 Sep 2009 19:42:35 +0100 [thread overview]
Message-ID: <20090902184234.GB10581@rakim.wolfsonmicro.main> (raw)
In-Reply-To: <1251756324-24216-1-git-send-email-linus.walleij@stericsson.com>
On Tue, Sep 01, 2009 at 12:05:24AM +0200, Linus Walleij wrote:
> This defines regulator platform data and board power
> regulator hogs for the ST-Ericsson U300 platform.
This is pretty much OK, just...
> +static struct regulator_consumer_supply supply_ldo_a[] = {
> + {
> + .dev = NULL,
> + .supply = "vrad", /* Powers the radio */
> + },
> +};
Now you're using the regulator init stuff to set the voltages you should
be able to drop most of the deviceless supplies. I'd expect that you'd
want to keep the CPU core supplies for cpufreq support but the others
shouldn't need to be defined. The names can be set in the constraints
- if set there they will be displayed to user space which normally makes
the diagnostics easier to follow for board users.
next prev parent reply other threads:[~2009-09-02 18:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-31 22:05 Linus Walleij
2009-09-02 18:42 ` Mark Brown [this message]
2009-09-02 21:39 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090902184234.GB10581@rakim.wolfsonmicro.main \
--to=broonie@opensource.wolfsonmicro.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=lrg@slimlogic.co.uk \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®