mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Oleg Nesterov <oleg@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	David Howells <dhowells@redhat.com>,
	James Morris <jmorris@namei.org>,
	Tom Horsley <tom.horsley@att.net>,
	linux-kernel@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH 1/1] exec: do not sleep in TASK_TRACED under ->cred_guard_mutex
Date: Thu,  3 Sep 2009 13:09:24 -0700 (PDT)	[thread overview]
Message-ID: <20090903200924.E46DF47C94@magilla.sf.frob.com> (raw)
In-Reply-To: Oleg Nesterov's message of  Thursday, 3 September 2009 18:05:14 +0200 <20090903160514.GA23646@redhat.com>

I certainly think it's right to hold the mutex only as long as necessary.
Clearly holding it when we stop is wrong.

I'm a bit concerned about holding it for arbitrary periods while we block
in the filesystem code.  e.g., consider the scenario with a hangs-forever
NFS server or suchlike.  But I'm not sure there is a reasonable way around
that one.

The paired calls that leave the mutex locked in between should have some
clear comments calling attention to their pairing.  Aside from that making
sure that subtlety is clear, I don't see any problems in the patch off hand.
But I haven't scoured the code path lately to have full confidence.
I'd like to hear David's reactions.


Thanks,
Roland

  reply	other threads:[~2009-09-03 20:12 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-03 16:05 Oleg Nesterov
2009-09-03 20:09 ` Roland McGrath [this message]
2009-09-04 13:39   ` Oleg Nesterov
2009-09-04 14:47   ` David Howells
2009-09-04 15:49     ` Oleg Nesterov
2009-09-04 17:26       ` [PATCH v3] " Oleg Nesterov
2009-09-04 19:42         ` Andrew Morton
2009-09-04 21:33           ` Oleg Nesterov
2009-09-09 21:57             ` Chuck Ebbert
2009-09-09 22:58               ` Oleg Nesterov
2009-09-04  8:39 ` [PATCH 1/1] " David Howells
2009-09-04  9:24   ` Roland McGrath
2009-09-04 12:46   ` Oleg Nesterov
2009-09-04 13:39   ` David Howells
2009-09-04 13:55     ` Oleg Nesterov
2009-09-04  8:43 ` David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090903200924.E46DF47C94@magilla.sf.frob.com \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhowells@redhat.com \
    --cc=jmorris@namei.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@redhat.com \
    --cc=stable@kernel.org \
    --cc=tom.horsley@att.net \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome