mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Matthew Garrett <mjg@redhat.com>
Cc: linux-kernel@vger.kernel.org, Matthew Garrett <mjg@redhat.com>
Subject: Re: [PATCH] VT: Add a boot option to disable cursor on boot
Date: Fri, 4 Sep 2009 18:03:02 +0100	[thread overview]
Message-ID: <20090904180302.6561fabf@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <1252079289-5383-1-git-send-email-mjg@redhat.com>

On Fri,  4 Sep 2009 11:48:09 -0400
Matthew Garrett <mjg@redhat.com> wrote:

> The VT code currently enables a visible cursor on boot. This is a fairly
> unnecessary visual distraction for setups which boot to a splash screen
> before going directly into X, so add a boot option (vt.hide_boot_cursor=1)
> that doesn't enable the cursor for initial VT setup. VT resets and any
> later VT creation will leave the cursor turned on, as before.

Seems odd to me - why can't the splash screen app in initrd just issue
the call to turn off the cursor - or is this splash screen coming from
something else ?

Either way the implementation in your patch is butt-ugly adding an extra
special case all over the place.

IMHO
- If the splash screen is kernel based then the splash screen module
  needs to be able to ask the vt driver itself
- If not then the user space can use ioctls like everyone else (see
  setterm)
- It should be implemented without adding an extra condition to a pile of
  ifs (or the condition mess at least become a single cursor_visible_p())

Alan

  reply	other threads:[~2009-09-04 16:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-04 15:48 Matthew Garrett
2009-09-04 17:03 ` Alan Cox [this message]
2009-09-04 16:15   ` Matthew Garrett

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090904180302.6561fabf@lxorguk.ukuu.org.uk \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®