mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw.cz>
To: Richard Purdie <rpurdie@rpsys.net>
Cc: lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>,
	Dirk@Opfer-Online.de, arminlitzel@web.de,
	Cyril Hrubis <metan@ucw.cz>,
	thommycheck@gmail.com,
	linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
	dbaryshkov@gmail.com, omegamoon@gmail.com, eric.miao@marvell.com,
	utx@penguin.cz
Subject: Re: Zaurus suspend saga
Date: Mon, 7 Sep 2009 13:31:32 +0200	[thread overview]
Message-ID: <20090907113132.GM23450@elf.ucw.cz> (raw)
In-Reply-To: <1252276145.17852.15.camel@dax.rpnet.com>

Hi!

> > fatal reads invalid values -- -108 -- probably because spi is not ready?
> > 
> > is spi suspend/resume required? yes.; and yes spi is resumed too late
> >  in the sequence. Or perhaps fatal battery check is way too early.
> > 
> > Could someone confirm that simply removing sharpsl_fatal_check() fixes
> > zaurus suspend on 2.6.31? 
> 
> Sadly lack of time means I've lost track of the Zaurus kernels but this
> sounds like all accesses to the SSP buses now go through the SPI layer
> and when it was converted nobody thought about the impact this would
> have on the Zaurus charger code.

Unfortunately... Do you have any idea when this conversion took place?

> If suspend/resume is broken in this way, it also means the charger code
> is also likely to be totally broken/malfunctioning since it won't be
> able to read from the ADC either.

Yes. Seems like low-level zaurus code is FUBAR.

> Either:
> 
> a) Someone steps up and finds a way to partially resume the kernel so
> the "offline" charging code can work and access SPI

> b) We find some other way to allow the SPI interface to be accessed by
> the charger code without resuming the whole kernel (the way it used to
> work)

Doing that in a hacky way should be rather easy... just calling spi
resume manually. But...

> c) We rip the whole thing out and stop supporting "offline" charging.

How much faster is offline charge, compared to online charging? I have
impression that online charging basically does not charge anything...

> I'd hate to see c) happen but I doubt I'm going to find time to rewrite
> that code any time soon and nobody else even seems to have grasped how
> deep this problem really is :(.

Well, I have a bit of time now and then...
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

  parent reply	other threads:[~2009-09-07 11:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-06  5:26 Pavel Machek
2009-09-06 17:03 ` Rafael J. Wysocki
2009-09-06 18:01   ` Stanislav Brabec
2009-09-07 10:04   ` Pavel Machek
2009-09-06 22:29 ` Richard Purdie
2009-09-07  1:06   ` Eric Miao
2009-09-07 11:03     ` Pavel Machek
2009-09-07 11:34       ` Stanislav Brabec
2009-09-07 11:48         ` Russell King - ARM Linux
2009-09-16 12:25           ` Stanislav Brabec
2009-10-02  4:13         ` Pavel Machek
2009-10-02  7:36           ` Joe Perches
2009-09-07 12:05       ` Dmitry Eremin-Solenikov
2009-09-07 11:31   ` Pavel Machek [this message]
2009-09-07 13:10     ` Stanislav Brabec
2009-09-07 14:07       ` Richard Purdie
2009-09-07 14:52         ` Eric Miao
2009-09-07 20:36         ` Dmitry Eremin-Solenikov
2009-09-07 14:46       ` Eric Miao
2009-09-08 21:19       ` Pavel Machek
2009-09-08 21:53       ` Pavel Machek
2009-09-09  9:28         ` Stanislav Brabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090907113132.GM23450@elf.ucw.cz \
    --to=pavel@ucw.cz \
    --cc=Dirk@Opfer-Online.de \
    --cc=arminlitzel@web.de \
    --cc=dbaryshkov@gmail.com \
    --cc=eric.miao@marvell.com \
    --cc=lenz@cs.wisc.edu \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metan@ucw.cz \
    --cc=omegamoon@gmail.com \
    --cc=rpurdie@rpsys.net \
    --cc=thommycheck@gmail.com \
    --cc=utx@penguin.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®