From: Jiri Olsa <jolsa@redhat.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 0/3] tracing - adding common method for reading/parsing user input
Date: Tue, 8 Sep 2009 16:37:11 +0200 [thread overview]
Message-ID: <20090908143711.GC3177@jolsa.lab.eng.brq.redhat.com> (raw)
In-Reply-To: <1252418499.13628.31.camel@gandalf.stny.rr.com>
On Tue, Sep 08, 2009 at 10:01:39AM -0400, Steven Rostedt wrote:
> On Sat, 2009-09-05 at 03:12 +0200, jolsa@redhat.com wrote:
> > As 3 different places for 4 user input files were using the same way
> > of reading and parsing user's input, I made one common routine to be
> > used.
> >
> > The mentioned files are:
> > set_graph_function
> > set_event
> > set_ftrace_filter
> > set_ftrace_notrace
> >
> > wbr,
> > jirka
> >
> > Signed-off-by: Jiri Olsa <jolsa@redhat.com>
>
> Looking back, this is pretty much exactly what I did back in February:
>
> http://lkml.org/lkml/2009/2/25/385
>
> The difference is that I wanted this to be a generic feature for things
> outside of tracing to use. I may just take my old patch and put the code
> in trace.c like you did.
>
> Thanks,
>
> -- Steve
>
>
ok, so are you going to take your patch, or should I do the changes you
proposed and send it out again?
wbr,
jirka
next prev parent reply other threads:[~2009-09-08 14:37 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-05 1:12 jolsa
2009-09-05 1:12 ` [PATCHv2 1/3] tracing - buf iterator definition, parsing function jolsa
2009-09-08 13:47 ` Steven Rostedt
2009-09-10 20:29 ` Steven Rostedt
2009-09-05 1:13 ` [PATCHv2 2/3] tracing - buf iterator support for set_event jolsa
2009-09-10 20:35 ` Steven Rostedt
2009-09-05 1:13 ` [PATCHv2 3/3] tracing - buf iterator support for set_graph_function set_ftrace_filter set_ftrace_notrace jolsa
2009-09-10 20:43 ` Steven Rostedt
2009-09-05 2:41 ` [PATCHv2 0/3] tracing - adding common method for reading/parsing user input Daniel Walker
2009-09-05 6:40 ` Jiri Olsa
2009-09-05 13:02 ` Steven Rostedt
2009-09-08 14:01 ` Steven Rostedt
2009-09-08 14:37 ` Jiri Olsa [this message]
2009-09-08 14:44 ` Steven Rostedt
2009-09-08 14:46 ` Jiri Olsa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090908143711.GC3177@jolsa.lab.eng.brq.redhat.com \
--to=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®