From: Roland McGrath <roland@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>
Cc: Jakub Jelinek <jakub@redhat.com>,
linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
x86@kernel.org
Subject: [PATCH 0/2] __builtin_unreachable
Date: Wed, 9 Sep 2009 18:59:23 -0700 (PDT) [thread overview]
Message-ID: <20090910015923.8FB628AE5F@magilla.sf.frob.com> (raw)
The latest GCC has a better way than "for (;;)" to indicate that a code
path cannot be reached due to reasons the compiler doesn't understand (such
as code in an asm). These patches provide UNREACHABLE() as a macro to hide
the details of this, and then use it for the BUG() macro on x86, saving
some dead code otherwise generated.
Other arch's BUG() may want to this too instead of "for (;;)" or __builtin_trap.
There are numerous matches from "git grep -n 'for *(;;) *;'" but it takes
someone who knows each bit of code to know where that means UNREACHABLE()
and where it really wants an infinite loop.
The following changes since commit 74fca6a42863ffacaf7ba6f1936a9f228950f657:
Linus Torvalds (1):
Linux 2.6.31
are available in the git repository at:
git://git.kernel.org/pub/scm/linux/kernel/git/frob/linux-2.6-roland.git topic/builtin_unreachable
Roland McGrath (2):
UNREACHABLE() macro
x86: BUG(): use UNREACHABLE()
arch/x86/include/asm/bug.h | 4 ++--
include/linux/compiler-gcc4.h | 13 +++++++++++++
include/linux/compiler.h | 9 +++++++++
3 files changed, 24 insertions(+), 2 deletions(-)
Thanks,
Roland
next reply other threads:[~2009-09-10 2:04 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-10 1:59 Roland McGrath [this message]
2009-09-10 2:00 ` [PATCH 1/2] UNREACHABLE() macro Roland McGrath
2009-09-11 20:45 ` Andrew Morton
2009-09-11 20:59 ` Kyle McMartin
2009-09-11 21:55 ` Roland McGrath
2009-09-12 3:49 ` Arjan van de Ven
2009-09-12 4:43 ` H. Peter Anvin
2009-09-12 5:30 ` Arjan van de Ven
2009-09-12 5:52 ` Andrew Morton
2009-09-12 6:38 ` Jakub Jelinek
2009-09-13 20:10 ` H. Peter Anvin
2009-09-10 2:01 ` [PATCH 2/2] x86: BUG(): use UNREACHABLE() Roland McGrath
2009-09-10 4:42 ` [PATCH 0/2] __builtin_unreachable Américo Wang
2009-09-10 6:42 ` H. Peter Anvin
2009-09-10 6:13 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090910015923.8FB628AE5F@magilla.sf.frob.com \
--to=roland@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=jakub@redhat.com \
--cc=linux-arch@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®